Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3045)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
index 204b90e92cca523e18cac520e64ca2e373cf11ef..4944871747e1c31327e6f280918249e26e453887 100644
--- a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
@@ -33,11 +33,20 @@ WorkerInspectorProxy::~WorkerInspectorProxy()
{
}
+WorkerThreadStartMode WorkerInspectorProxy::workerStartMode(ExecutionContext* context)
+{
+ if (InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart(context))
+ return PauseWorkerGlobalScopeOnStart;
+ return DontPauseWorkerGlobalScopeOnStart;
+}
+
void WorkerInspectorProxy::workerThreadCreated(ExecutionContext* context, WorkerThread* workerThread, const KURL& url)
{
m_workerThread = workerThread;
m_executionContext = context;
- InspectorInstrumentation::didStartWorker(context, this, url);
+ // We expect everyone starting worker thread to synchronously ask for workerStartMode right before.
+ bool pausedOnStart = InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart(context);
pfeldman 2016/02/09 22:42:56 So you are passing the value you got back into ins
dgozman 2016/02/09 23:45:28 Otherwise instrumenting agent must assume shouldPa
+ InspectorInstrumentation::didStartWorker(context, this, url, pausedOnStart);
}
void WorkerInspectorProxy::workerThreadTerminated()

Powered by Google App Engine
This is Rietveld 408576698