sync: Add helper class for P2P invalidations

sync: Add helper class for P2P invalidations

Introduces the P2PInvalidationForwarder.  This class listens to
ProfileSyncService events and generates P2P invalidations when it sees
that the ProfileSyncServce has committed something.  This is useful only
in tests, where we do not have a real (non-P2P) invalidations.

The P2PInvalidationForwarder's functionality is not new.  It used to
reside in the ProfileSyncServiceHarness.  Moving it into this new class
is a step towards making the ProfileSyncServiceHarness not listen to
ProfileSyncService events.

BUG=323380
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252224

[rlarocque, 2014-02-14 23:35:47]

Here's another patch broken off of https://codereview.chromium.org/165393010/.

Fortunately, it doesn't conflict with the first one
(https://codereview.chromium.org/167873002/), so the two can be reviewed and
committed in parallel.

Please review.

[rlarocque, 2014-02-19 19:08:39]

Friendly ping.

[haitaol1, 2014-02-19 21:15:21]

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
File chrome/browser/sync/test/integration/profile_sync_service_harness.cc
(right):

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:211: new
P2PInvalidationForwarder(service(), p2p_invalidation_service_));
You don't need p2p_invalidation_service_ if creating p2p_invalidation_forwarder_
in constructor.

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:318: //
Integration tests still use p2p notifications.
obsolete comment?

[rlarocque, 2014-02-19 22:21:14]

Patch updated.  PTAL.

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
File chrome/browser/sync/test/integration/profile_sync_service_harness.cc
(right):

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:211: new
P2PInvalidationForwarder(service(), p2p_invalidation_service_));
On 2014/02/19 21:15:21, haitaol1 wrote:
> You don't need p2p_invalidation_service_ if creating
p2p_invalidation_forwarder_
> in constructor.

Good point.  I hadn't thought of that.

Fixed.

https://codereview.chromium.org/167913002/diff/1/chrome/browser/sync/test/int...
chrome/browser/sync/test/integration/profile_sync_service_harness.cc:318: //
Integration tests still use p2p notifications.
On 2014/02/19 21:15:21, haitaol1 wrote:
> obsolete comment?

Correct.  Removed.

[haitaol1, 2014-02-19 23:02:52]

lgtm

[rlarocque, 2014-02-19 23:03:24]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-02-19 23:19:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167913002/100001

[commit-bot: I haz the power, 2014-02-20 01:11:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167913002/100001

[commit-bot: I haz the power, 2014-02-20 04:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167913002/100001

[commit-bot: I haz the power, 2014-02-20 08:55:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167913002/100001

[commit-bot: I haz the power, 2014-02-20 12:23:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/167913002/100001

[commit-bot: I haz the power, 2014-02-20 13:45:47]

Change committed as 252224