[regexp] implement RegExp.prototype.toString for non-RegExp receiver.

[regexp] implement RegExp.prototype.toString for non-RegExp receiver.

R=littledan@chromium.org, verwaest@chromium.org
BUG=v8:4524
LOG=N

Committed: https://crrev.com/1d5a50d35d300c73ebe46fc2c8a893e7c3d2ec11
Cr-Commit-Position: refs/heads/master@{#33862}

[Toon Verwaest, 2016-02-10 10:11:21]

lgtm with comment

https://codereview.chromium.org/1679123007/diff/1/src/js/regexp.js
File src/js/regexp.js (right):

https://codereview.chromium.org/1679123007/diff/1/src/js/regexp.js#newcode281
src/js/regexp.js:281: if (!IS_OBJECT(this)) {
This should be IS_RECEIVER or so. IS_OBJECT is just typeof this == "object",
which returns true for null.

Please add a test for this. As well as for other non-Object receivers with valid
.flags/.pattern functions on their intrinsicDefaultProto.

[Dan Ehrenberg, 2016-02-10 10:17:42]

lgtm

LGTM modulo Toon's comments

[Yang, 2016-02-10 10:24:52]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-10 10:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1679123007/#ps20001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-02-10 10:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679123007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679123007/20001

[Yang, 2016-02-10 10:25:11]

On 2016/02/10 10:17:42, Dan Ehrenberg wrote:
> lgtm
> 
> LGTM modulo Toon's comments

Addressed comments and improved test case.

[commit-bot: I haz the power, 2016-02-10 10:53:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-10 10:53:37]

Description was changed from

==========
[regexp] implement RegExp.prototype.toString for non-RegExp receiver.

R=littledan@chromium.org, verwaest@chromium.org
BUG=v8:4524
LOG=N
==========

to

==========
[regexp] implement RegExp.prototype.toString for non-RegExp receiver.

R=littledan@chromium.org, verwaest@chromium.org
BUG=v8:4524
LOG=N

Committed: https://crrev.com/1d5a50d35d300c73ebe46fc2c8a893e7c3d2ec11
Cr-Commit-Position: refs/heads/master@{#33862}
==========

[commit-bot: I haz the power, 2016-02-10 10:53:38]

Patchset 2 (id:??) landed as
https://crrev.com/1d5a50d35d300c73ebe46fc2c8a893e7c3d2ec11
Cr-Commit-Position: refs/heads/master@{#33862}