Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: net/quic/quic_connection.cc

Issue 1679113002: QUIC - Make |visitor_| nullptr check consistent with other nullptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index a7aca6f1cef913eb953a87c8dd1af21a665d0541..d5cdded5c478f3c6942b948c05c2832cdc706dec 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -2077,7 +2077,7 @@ void QuicConnection::CloseConnection(QuicErrorCode error, bool from_peer) {
// TODO(rtenneti): crbug.com/546668. A temporary fix. Added a check for null
// |visitor_| to fix crash bug. Delete |visitor_| check and histogram after
// fix is merged.
- if (visitor_) {
+ if (visitor_ != nullptr) {
visitor_->OnConnectionClosed(error, from_peer);
} else {
UMA_HISTOGRAM_BOOLEAN("Net.QuicCloseConnection.NullVisitor", true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698