Several pure virtual IFWL_Adapter* classes not implemented.

Several pure virtual IFWL_Adapter* classes not implemented.

The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL.  Those must
have been bugs; treat such cases as unreachable.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c74acf4552944c5485b1175c008708d19b57d322

[Tom Sepez, 2016-02-09 00:18:35]

Description was changed from

==========
Several pure virtual IFWL_Adapter* classes not implemented.
==========

to

==========
Several pure virtual IFWL_Adapter* classes not implemented.

The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL.  Those must
have been bugs; treat such cases as unreachable.
==========

[Tom Sepez, 2016-02-09 00:18:35]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-09 00:20:32]

Lei, nothing but red.

https://codereview.chromium.org/1679103002/diff/20001/xfa/src/fwl/src/basewid...
File xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp (left):

https://codereview.chromium.org/1679103002/diff/20001/xfa/src/fwl/src/basewid...
xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:1793: FWL_HCURSOR hCursor =
pCursorMgr->GetSystemCursor(FWL_CURSORTYPE_SizeNS);
segv.

https://codereview.chromium.org/1679103002/diff/20001/xfa/src/fwl/src/basewid...
xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:1826: FWL_HCURSOR hCursor =
pCursorMgr->GetSystemCursor(cursorType);
segv.

[Lei Zhang, 2016-02-09 00:59:59]

lgtm assuming segv -> not reachable.

[Tom Sepez, 2016-02-09 17:46:25]

On 2016/02/09 00:59:59, Lei Zhang wrote:
> lgtm assuming segv -> not reachable.
That's what I had to assume, right?

[Tom Sepez, 2016-02-09 18:18:14]

Description was changed from

==========
Several pure virtual IFWL_Adapter* classes not implemented.

The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL.  Those must
have been bugs; treat such cases as unreachable.
==========

to

==========
Several pure virtual IFWL_Adapter* classes not implemented.

The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL.  Those must
have been bugs; treat such cases as unreachable.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/c74acf4552944c5485b1175c008708d19b57...
==========

[Tom Sepez, 2016-02-09 18:18:15]

Committed patchset #2 (id:20001) manually as
c74acf4552944c5485b1175c008708d19b57d322 (presubmit successful).

[Lei Zhang, 2016-02-09 18:57:36]

On 2016/02/09 17:46:25, Tom Sepez wrote:
> On 2016/02/09 00:59:59, Lei Zhang wrote:
> > lgtm assuming segv -> not reachable.
> That's what I had to assume, right?

Well, if it turns out we need cursor handling in the future, we can always
revisit the removed code.