Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1679093002: Use ShouldResemble instead of ShouldResembleV. (Closed)

Created:
4 years, 10 months ago by dnj
Modified:
4 years, 10 months ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Use ShouldResemble instead of ShouldResembleV. Now that goconvey incorporates our ShouldResembleV method directly, we can go back to using ShouldResemble instead of hacking in ShouldResembleV! BUG=None Committed: https://github.com/luci/gae/commit/b272adef2808bbf770e47e1c681843f8d6f5d2cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M filter/txnBuf/txnbuf_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_query_execution_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/mail_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M impl/memory/user_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M service/datastore/datastore_test.go View 9 chunks +10 lines, -10 lines 0 comments Download
M service/datastore/pls_test.go View 1 chunk +1 line, -1 line 0 comments Download
M service/mail/message_test.go View 2 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 10 months ago (2016-02-08 23:56:22 UTC) #2
iannucci
lgtm
4 years, 10 months ago (2016-02-09 00:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679093002/1
4 years, 10 months ago (2016-02-09 00:45:51 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 00:51:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/b272adef2808bbf770e47e1c681843f8d6f5d2cc

Powered by Google App Engine
This is Rietveld 408576698