ash/mash: Make sure the right context-factory is used for the views::Widgets.

ash/mash: Make sure the right context-factory is used for the views::Widgets.

Make sure NativeWidgetMus installs the ui::ContextFactory for the views::Widgets,
and doesn't use the stub context-factory installed for the AshWindowTreeHosts.

BUG=585141
Committed: https://crrev.com/db54817425168a225d0f14f2c61f30082f015723
Cr-Commit-Position: refs/heads/master@{#374685}

[sadrul, 2016-02-10 07:56:52]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-02-10 17:27:43]

LGTM - I would like a less error prone solution, but you can land this now.

https://codereview.chromium.org/1679023007/diff/1/ash/mus/sysui_application.cc
File ash/mus/sysui_application.cc (right):

https://codereview.chromium.org/1679023007/diff/1/ash/mus/sysui_application.c...
ash/mus/sysui_application.cc:113: views::NativeWidgetMus* native_widget =
I think this code (and NativeWidgetMus too) shows how fragile the static factory
is. Can we explicitly pass in the factory we want to use?

[sadrul, 2016-02-10 17:29:36]

https://codereview.chromium.org/1679023007/diff/1/ash/mus/sysui_application.cc
File ash/mus/sysui_application.cc (right):

https://codereview.chromium.org/1679023007/diff/1/ash/mus/sysui_application.c...
ash/mus/sysui_application.cc:113: views::NativeWidgetMus* native_widget =
On 2016/02/10 17:27:43, sky wrote:
> I think this code (and NativeWidgetMus too) shows how fragile the static
factory
> is. Can we explicitly pass in the factory we want to use?

Agree. I started looking at that, but decided to unblock this first. I will land
this, and look into a cleaner solution.

[sadrul, 2016-02-10 17:46:19]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-02-10 17:48:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679023007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679023007/1

[commit-bot: I haz the power, 2016-02-10 18:00:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-10 18:01:55]

Description was changed from

==========
ash/mash: Make sure the right context-factory is used for the views::Widgets.

Make sure NativeWidgetMus installs the ui::ContextFactory for the
views::Widgets,
and doesn't use the stub context-factory installed for the AshWindowTreeHosts.

BUG=585141
==========

to

==========
ash/mash: Make sure the right context-factory is used for the views::Widgets.

Make sure NativeWidgetMus installs the ui::ContextFactory for the
views::Widgets,
and doesn't use the stub context-factory installed for the AshWindowTreeHosts.

BUG=585141

Committed: https://crrev.com/db54817425168a225d0f14f2c61f30082f015723
Cr-Commit-Position: refs/heads/master@{#374685}
==========

[commit-bot: I haz the power, 2016-02-10 18:01:56]

Patchset 1 (id:??) landed as
https://crrev.com/db54817425168a225d0f14f2c61f30082f015723
Cr-Commit-Position: refs/heads/master@{#374685}