Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: mojo/ui/view_provider_app.cc

Issue 1679023006: Reify view ownership as a message pipe. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/ui/view_provider_app.h ('k') | services/ui/launcher/launcher_app.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/ui/view_provider_app.cc
diff --git a/mojo/ui/view_provider_app.cc b/mojo/ui/view_provider_app.cc
index 40d5a5bc8e526484fa9c4577821fb575eb0a1730..e7b9dd5a54fd58719550e716f0fd6c87e9418555 100644
--- a/mojo/ui/view_provider_app.cc
+++ b/mojo/ui/view_provider_app.cc
@@ -21,11 +21,11 @@ class ViewProviderApp::DelegatingViewProvider : public mojo::ui::ViewProvider {
private:
// |ViewProvider|:
void CreateView(
+ mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
- const mojo::ui::ViewProvider::CreateViewCallback& callback) override {
- app_->CreateView(this, view_provider_url_, services.Pass(),
- exposed_services.Pass(), callback);
+ mojo::ServiceProviderPtr exposed_services) override {
+ app_->CreateView(this, view_provider_url_, view_owner_request.Pass(),
+ services.Pass(), exposed_services.Pass());
}
ViewProviderApp* app_;
@@ -65,14 +65,11 @@ void ViewProviderApp::Create(
void ViewProviderApp::CreateView(
DelegatingViewProvider* provider,
const std::string& view_provider_url,
+ mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,
mojo::InterfaceRequest<mojo::ServiceProvider> services,
- mojo::ServiceProviderPtr exposed_services,
- const mojo::ui::ViewProvider::CreateViewCallback& callback) {
- if (!CreateView(view_provider_url, services.Pass(), exposed_services.Pass(),
- callback)) {
- bindings_.RemoveBindings(provider);
- delete provider;
- }
+ mojo::ServiceProviderPtr exposed_services) {
+ CreateView(view_provider_url, view_owner_request.Pass(), services.Pass(),
+ exposed_services.Pass());
}
} // namespace ui
« no previous file with comments | « mojo/ui/view_provider_app.h ('k') | services/ui/launcher/launcher_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698