Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: mojo/ui/base_view.cc

Issue 1679023006: Reify view ownership as a message pipe. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/ui/base_view.h ('k') | mojo/ui/ganesh_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/ui/base_view.cc
diff --git a/mojo/ui/base_view.cc b/mojo/ui/base_view.cc
index b58faf4104e0f0ef0138561587a0f7020763c35b..7ff00684f80bd69a4870defb5bdce15370841a63 100644
--- a/mojo/ui/base_view.cc
+++ b/mojo/ui/base_view.cc
@@ -11,16 +11,16 @@ namespace ui {
BaseView::BaseView(
mojo::ApplicationImpl* app_impl,
- const std::string& label,
- const mojo::ui::ViewProvider::CreateViewCallback& create_view_callback)
+ mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,
+ const std::string& label)
: app_impl_(app_impl), view_binding_(this) {
DCHECK(app_impl_);
app_impl_->ConnectToService("mojo:view_manager_service", &view_manager_);
mojo::ui::ViewPtr view;
view_binding_.Bind(mojo::GetProxy(&view));
- view_manager_->RegisterView(view.Pass(), mojo::GetProxy(&view_host_), label,
- create_view_callback);
+ view_manager_->RegisterView(view.Pass(), mojo::GetProxy(&view_host_),
+ view_owner_request.Pass(), label);
view_host_->CreateScene(mojo::GetProxy(&scene_));
view_host_->GetServiceProvider(mojo::GetProxy(&view_service_provider_));
}
« no previous file with comments | « mojo/ui/base_view.h ('k') | mojo/ui/ganesh_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698