appengine/memlock/memlock.go - Issue 1679023005: Add Context cancellation to clock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/memlock/memlock.go

Issue 1679023005: Add Context cancellation to clock. (Closed) Base URL: https://github.com/luci/luci-go@master

Patch Set: Cleanup memlock, restore old determinism, better name. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/memlock/memlock.go

diff --git a/appengine/memlock/memlock.go b/appengine/memlock/memlock.go

index b0f14f5c663f5b579f1f53989469ccdd6522799d..7eefeb0d0d1bc495bafc116ac2bfa754cc2c66d0 100644

--- a/appengine/memlock/memlock.go

+++ b/appengine/memlock/memlock.go

@@ -152,12 +152,9 @@ func TryWithLock(ctx context.Context, key, clientID string, f func(context.Conte

close(finished)

}()

- checkLoop:

for {

- select {

- case <-subCtx.Done():

- break checkLoop

- case <-clock.Get(ctx).After(delay):

+ if (<-clock.After(subCtx, delay)).Err != nil {

dnj (Google) 2016/02/10 03:40:08 Nice, eh?

+ break

}

if !checkAnd(refresh) {

log.Warningf("lost lock: %s", err)

« no previous file with comments | « no previous file | common/clock/clock.go » ('j') | common/clock/testclock/testclock.go » ('J')