chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java - Issue 1678943002: DataUse UI strings should be changeable via Finch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

Issue 1678943002: DataUse UI strings should be changeable via Finch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc » ('j') | chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

index ea5eb39987ac0cf04f04176a48acd8b2d5c2c730..3022b98fac45b6934f328625f4a400788fdef558 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

@@ -39,20 +39,28 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro

}

public void showDataUseTrackingStartedBar() {

- mSnackbarManager.showSnackbar(Snackbar

- .make(mContext.getString(R.string.data_use_tracking_started_snackbar_message), this,

- Snackbar.TYPE_NOTIFICATION)

- .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),

- STARTED_SNACKBAR));

+ mSnackbarManager.showSnackbar(

+ Snackbar.make(DataUseTabUIManager.getUIMessage(

+ DataUseTabUIManager.DataUseUIMessage

+ .DATA_USE_TRACKING_STARTED_SNACKBAR_MESSAGE),

+ this, Snackbar.TYPE_NOTIFICATION)

+ .setAction(DataUseTabUIManager.getUIMessage(

+ DataUseTabUIManager.DataUseUIMessage

+ .DATA_USE_TRACKING_SNACKBAR_ACTION),

+ STARTED_SNACKBAR));

DataUseTabUIManager.recordDataUseUIAction(DataUsageUIAction.STARTED_SNACKBAR_SHOWN);

}

public void showDataUseTrackingEndedBar() {

- mSnackbarManager.showSnackbar(Snackbar

- .make(mContext.getString(R.string.data_use_tracking_ended_snackbar_message), this,

- Snackbar.TYPE_NOTIFICATION)

- .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),

- ENDED_SNACKBAR));

+ mSnackbarManager.showSnackbar(

+ Snackbar.make(DataUseTabUIManager.getUIMessage(

+ DataUseTabUIManager.DataUseUIMessage

+ .DATA_USE_TRACKING_ENDED_SNACKBAR_MESSAGE),

+ this, Snackbar.TYPE_NOTIFICATION)

+ .setAction(DataUseTabUIManager.getUIMessage(

+ DataUseTabUIManager.DataUseUIMessage

+ .DATA_USE_TRACKING_SNACKBAR_ACTION),

+ ENDED_SNACKBAR));

DataUseTabUIManager.recordDataUseUIAction(DataUsageUIAction.ENDED_SNACKBAR_SHOWN);

}