WebGL: Remove some unused members in WebGLRenderingContext.

Source/core/html/canvas/WebGLRenderingContext.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 504 matching lines @@
 
     bool m_synthesizedErrorsToConsole;
     int m_numGLErrorsToConsoleAllowed;
 
     bool m_multisamplingAllowed;
     bool m_multisamplingObserverRegistered;
 
     GLuint m_onePlusMaxEnabledAttribIndex;
     unsigned long m_onePlusMaxNonDefaultTextureUnit;
 
-    bool m_preserveDrawingBuffer;
     OwnPtr<Extensions3DUtil> m_extensionsUtil;
 
     // Enabled extension objects.
     RefPtr<ANGLEInstancedArrays> m_angleInstancedArrays;
     RefPtr<EXTFragDepth> m_extFragDepth;
     RefPtr<EXTTextureFilterAnisotropic> m_extTextureFilterAnisotropic;
     RefPtr<OESTextureFloat> m_oesTextureFloat;
     RefPtr<OESTextureFloatLinear> m_oesTextureFloatLinear;
     RefPtr<OESTextureHalfFloat> m_oesTextureHalfFloat;
     RefPtr<OESTextureHalfFloatLinear> m_oesTextureHalfFloatLinear;
@@ skipping 69 matching lines @@
 
     template <typename T>
     class TypedExtensionTracker FINAL : public ExtensionTracker {
     public:
         TypedExtensionTracker(RefPtr<T>& extensionField, ExtensionFlags flags, const char* const* prefixes)
             : ExtensionTracker(flags, prefixes)
             , m_extensionField(extensionField)
         {
         }
 
-        ~TypedExtensionTracker()
+        virtual ~TypedExtensionTracker()

[Ken Russell (switch to Gerrit), 2014/02/19 20:23:10]

This change is unnecessary because ExtensionTracker's destructor is virtual.

#include <iostream>

using namespace std;

class A {
 public:
  A() { cout << "A::A()" << endl; }
  virtual ~A() { cout << "A::~A()" << endl; }
};

class B : public A {
 public:
  B() { cout << "B::B()" << endl; }
  ~B() { cout << "B::~B()" << endl; }
};

int main(int argc, char** argv) {
  A* p = new B();
  delete p;
}

[piman, 2014/02/19 20:28:24]

There's a style rule in chromium land that says that overriding methods (and
destructor) should be marked virtual for clarity.
Is it not the case in blink land?

[Ken Russell (switch to Gerrit), 2014/02/19 21:08:13]

I'd forgotten so went back and looked. The Blink style guide is silent on this
issue so the Google C++ style guide should be used. Yes, you're right, the
derived class should use the "virtual" keyword.

However, there is no memory leak in the current code, so the CL description is
wrong. It should say something like "Mark TypedExtensionTracker's destructor
virtual for clarity."

         {
             if (m_extensionField) {
                 m_extensionField->lose(true);
                 m_extensionField = 0;
             }
         }
 
         virtual PassRefPtr<WebGLExtension> getExtension(WebGLRenderingContext* context) const OVERRIDE
         {
             if (!m_extensionField)
@@ skipping 65 matching lines @@
     void createFallbackBlackTextures1x1();
 
     // Helper function for copyTex{Sub}Image, check whether the internalformat
     // and the color buffer format of the current bound framebuffer combination
     // is valid.
     bool isTexInternalFormatColorBufferCombinationValid(GLenum texInternalFormat, GLenum colorBufferFormat);
 
     // Helper function to get the bound framebuffer's color buffer format.
     GLenum boundFramebufferColorFormat();
 
-    // Helper function to get the bound framebuffer's width.
-    int boundFramebufferWidth();
-
-    // Helper function to get the bound framebuffer's height.
-    int boundFramebufferHeight();
-
     // Helper function to verify limits on the length of uniform and attribute locations.
     bool validateLocationLength(const char* functionName, const String&);
 
     // Helper function to check if size is non-negative.
     // Generate GL error and return false for negative inputs; otherwise, return true.
     bool validateSize(const char* functionName, GLint x, GLint y);
 
     // Helper function to check if all characters in the string belong to the
     // ASCII subset as defined in GLSL ES 1.0 spec section 3.1.
     bool validateString(const char* functionName, const String&);
@@ skipping 207 matching lines @@
     // If the vector is empty, return the maximum allowed active context number.
     static size_t oldestContextIndex();
     static IntSize oldestContextSize();
 };
 
 DEFINE_TYPE_CASTS(WebGLRenderingContext, CanvasRenderingContext, context, context->is3d(), context.is3d());
 
 } // namespace WebCore
 
 #endif