Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: runtime/vm/stub_code_mips.cc

Issue 167893006: MIPS: Fix bug in allocation stub's slow path. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: updated status file Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1378 matching lines...) Expand 10 before | Expand all | Expand 10 after
1389 __ lw(T1, Address(SP, 0 * kWordSize)); 1389 __ lw(T1, Address(SP, 0 * kWordSize));
1390 } 1390 }
1391 __ Bind(&slow_case_with_type_arguments); 1391 __ Bind(&slow_case_with_type_arguments);
1392 // If is_cls_parameterized: 1392 // If is_cls_parameterized:
1393 // T1: new object type arguments (instantiated or not). 1393 // T1: new object type arguments (instantiated or not).
1394 // Create a stub frame as we are pushing some objects on the stack before 1394 // Create a stub frame as we are pushing some objects on the stack before
1395 // calling into the runtime. 1395 // calling into the runtime.
1396 __ EnterStubFrame(true); // Uses pool pointer to pass cls to runtime. 1396 __ EnterStubFrame(true); // Uses pool pointer to pass cls to runtime.
1397 __ LoadObject(TMP, cls); 1397 __ LoadObject(TMP, cls);
1398 1398
1399 __ addiu(SP, SP, Immediate(-4 * kWordSize)); 1399 __ addiu(SP, SP, Immediate(-3 * kWordSize));
1400 // Space on stack for return value. 1400 // Space on stack for return value.
1401 __ LoadImmediate(T7, reinterpret_cast<intptr_t>(Object::null())); 1401 __ LoadImmediate(T7, reinterpret_cast<intptr_t>(Object::null()));
1402 __ sw(T7, Address(SP, 2 * kWordSize)); 1402 __ sw(T7, Address(SP, 2 * kWordSize));
1403 __ sw(TMP, Address(SP, 1 * kWordSize)); // Class of object to be allocated. 1403 __ sw(TMP, Address(SP, 1 * kWordSize)); // Class of object to be allocated.
1404 1404
1405 if (is_cls_parameterized) { 1405 if (is_cls_parameterized) {
1406 // Push type arguments of object to be allocated and of instantiator. 1406 // Push type arguments of object to be allocated and of instantiator.
1407 __ sw(T1, Address(SP, 0 * kWordSize)); 1407 __ sw(T1, Address(SP, 0 * kWordSize));
1408 } else { 1408 } else {
1409 // Push null type arguments. 1409 // Push null type arguments.
(...skipping 978 matching lines...) Expand 10 before | Expand all | Expand 10 after
2388 const Register right = T0; 2388 const Register right = T0;
2389 __ lw(left, Address(SP, 1 * kWordSize)); 2389 __ lw(left, Address(SP, 1 * kWordSize));
2390 __ lw(right, Address(SP, 0 * kWordSize)); 2390 __ lw(right, Address(SP, 0 * kWordSize));
2391 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp1, temp2); 2391 GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp1, temp2);
2392 __ Ret(); 2392 __ Ret();
2393 } 2393 }
2394 2394
2395 } // namespace dart 2395 } // namespace dart
2396 2396
2397 #endif // defined TARGET_ARCH_MIPS 2397 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | tests/language/vm/regress_16873_test.dart » ('j') | tests/language/vm/regress_16873_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698