Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 167893003: Update tts to include new voices (Closed)

Created:
6 years, 10 months ago by Zachary Kuznia
Modified:
6 years, 10 months ago
Reviewers:
Dmitry Polukhin, Nico
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Update tts to include new voices BUG=333288 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251970

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fix #

Total comments: 6

Patch Set 3 : Fix name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -38 lines) Patch
M chrome/browser/resources/chromeos/speech_synthesis/manifest.json View 1 2 2 chunks +53 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/speech_synthesis/manifest_guest.json View 1 2 2 chunks +53 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Zachary Kuznia
6 years, 10 months ago (2014-02-15 02:18:38 UTC) #1
Dmitry Polukhin
lgtm https://codereview.chromium.org/167893003/diff/1/chrome/browser/resources/chromeos/speech_synthesis/manifest.json File chrome/browser/resources/chromeos/speech_synthesis/manifest.json (right): https://codereview.chromium.org/167893003/diff/1/chrome/browser/resources/chromeos/speech_synthesis/manifest.json#newcode27 chrome/browser/resources/chromeos/speech_synthesis/manifest.json:27: { We usually avoid HTTP in permissions for ...
6 years, 10 months ago (2014-02-15 05:16:22 UTC) #2
Zachary Kuznia
https://codereview.chromium.org/167893003/diff/1/chrome/browser/resources/chromeos/speech_synthesis/manifest.json File chrome/browser/resources/chromeos/speech_synthesis/manifest.json (right): https://codereview.chromium.org/167893003/diff/1/chrome/browser/resources/chromeos/speech_synthesis/manifest.json#newcode27 chrome/browser/resources/chromeos/speech_synthesis/manifest.json:27: { On 2014/02/15 05:16:22, Dmitry Polukhin wrote: > We ...
6 years, 10 months ago (2014-02-18 23:49:12 UTC) #3
Zachary Kuznia
Hello thakis, Could you do an OWNERS review of this? Thanks, -Zach
6 years, 10 months ago (2014-02-18 23:49:34 UTC) #4
Nico
lgtm stamp, but I have no idea what's going on here :-) https://codereview.chromium.org/167893003/diff/110001/chrome/browser/resources/chromeos/speech_synthesis/manifest.json File chrome/browser/resources/chromeos/speech_synthesis/manifest.json ...
6 years, 10 months ago (2014-02-19 00:45:50 UTC) #5
Zachary Kuznia
https://codereview.chromium.org/167893003/diff/110001/chrome/browser/resources/chromeos/speech_synthesis/manifest.json File chrome/browser/resources/chromeos/speech_synthesis/manifest.json (right): https://codereview.chromium.org/167893003/diff/110001/chrome/browser/resources/chromeos/speech_synthesis/manifest.json#newcode4 chrome/browser/resources/chromeos/speech_synthesis/manifest.json:4: "name": "US English Female Text-to-speech (by Google)", On 2014/02/19 ...
6 years, 10 months ago (2014-02-19 01:02:47 UTC) #6
Zachary Kuznia
The CQ bit was checked by zork@chromium.org
6 years, 10 months ago (2014-02-19 01:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/167893003/230001
6 years, 10 months ago (2014-02-19 01:05:16 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:28:49 UTC) #9
Message was sent while issue was closed.
Change committed as 251970

Powered by Google App Engine
This is Rietveld 408576698