Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 167893002: Roll webrtc to r5549. (Closed)

Created:
6 years, 10 months ago by Mallinath (Gone from Chromium)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org, jam, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Roll webrtc to r5549. Major change in this revision is addition of PacketOptions structure to every packet sent over network in AsyncPacketSocket::Send methods. This structure has information about parameters required for packet authentication outside libsrtp. R=ronghuawu@chromium.org, sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251548

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M jingle/glue/fake_socket_factory.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/fake_socket_factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/jingle_glue/chromium_socket_factory.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/jingle_glue/chromium_socket_factory_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mallinath (Gone from Chromium)
6 years, 10 months ago (2014-02-14 23:21:13 UTC) #1
Ronghua Wu (Left Chromium)
LGTM Will be nice to have some background about the packetoptions in the cl description.
6 years, 10 months ago (2014-02-14 23:25:20 UTC) #2
Mallinath (Gone from Chromium)
6 years, 10 months ago (2014-02-14 23:44:57 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/167893002/diff/1/jingle/glue/channel_socket_adapter.cc File jingle/glue/channel_socket_adapter.cc (right): https://codereview.chromium.org/167893002/diff/1/jingle/glue/channel_socket_adapter.cc#newcode79 jingle/glue/channel_socket_adapter.cc:79: talk_base::PacketOptions options; move this inside of the if ...
6 years, 10 months ago (2014-02-15 00:12:28 UTC) #4
Sergey Ulanov
On 2014/02/14 23:25:20, Ronghua Wu wrote: > Will be nice to have some background about ...
6 years, 10 months ago (2014-02-15 00:12:58 UTC) #5
Mallinath (Gone from Chromium)
6 years, 10 months ago (2014-02-15 06:09:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r251548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698