Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1678923002: Reland of SkTArray to move when moving. (Closed)

Created:
4 years, 10 months ago by kjlubick
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of SkTArray to move when moving. (patchset #1 id:1 of https://codereview.chromium.org/1677103002/ ) Reason for revert: This was not the problem. Original issue's description: > Revert of SkTArray to move when moving. (patchset #3 id:40001 of https://codereview.chromium.org/1672063002/ ) > > Reason for revert: > This appears to have broken several things. > > Original issue's description: > > SkTArray to move when moving. > > > > This updates SkTArray to move elements when possible, instead of always > > copying them. > > > > TBR=reed > > Agreed moving is good. This should also become private. > > > > Committed: https://skia.googlesource.com/skia/+/3c69348e725131150e4ab962dec1b3ff1148a6bd > > TBR=reed@google.com,mtklein@google.com,bungeman@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/2f8c9bf96ceea9d13fb0fc29285ecaf1673f2e8b TBR=reed@google.com,mtklein@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f5b8b6dd54623be3938d6497ff46d3fd10a4089a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -52 lines) Patch
M include/core/SkTArray.h View 8 chunks +34 lines, -50 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjlubick
Created Reland of SkTArray to move when moving.
4 years, 10 months ago (2016-02-08 18:19:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678923002/1
4 years, 10 months ago (2016-02-08 18:20:09 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 18:20:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f5b8b6dd54623be3938d6497ff46d3fd10a4089a

Powered by Google App Engine
This is Rietveld 408576698