Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1678903003: [interpreter] Re-enable test-interpreter/ClassDeclarations. (Closed)

Created:
4 years, 10 months ago by oth
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Re-enable test-interpreter/ClassDeclarations. BUG=v8:4280, v8:4682 LOG=N R=rmcilroy@chromium.org Committed: https://crrev.com/8e362a209637158c47cfaad97a8ee5a66c375cd4 Cr-Commit-Position: refs/heads/master@{#33844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -28 lines) Patch
M test/cctest/interpreter/test-bytecode-generator.cc View 8 chunks +50 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
oth
PTAL, thanks.
4 years, 10 months ago (2016-02-09 11:03:57 UTC) #1
rmcilroy
LGTM, thanks! Did you try Stephano's tool? :)
4 years, 10 months ago (2016-02-09 11:13:20 UTC) #2
oth
Committed patchset #1 (id:1) manually as 8e362a209637158c47cfaad97a8ee5a66c375cd4 (presubmit successful).
4 years, 10 months ago (2016-02-09 11:44:14 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 11:44:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e362a209637158c47cfaad97a8ee5a66c375cd4
Cr-Commit-Position: refs/heads/master@{#33844}

Powered by Google App Engine
This is Rietveld 408576698