Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1678893003: moved debugger support files from src/utils/debugger to tools/debugger (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3398 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/debugger.gyp View 2 chunks +9 lines, -9 lines 0 comments Download
M gyp/dm.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M gyp/gmslides.gypi View 2 chunks +9 lines, -9 lines 0 comments Download
M gyp/skiaserve.gyp View 1 chunk +9 lines, -9 lines 0 comments Download
M gyp/tests.gypi View 2 chunks +9 lines, -9 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -1 line 0 comments Download
D src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -269 lines 0 comments Download
D src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -624 lines 0 comments Download
D src/utils/debugger/SkDrawCommand.h View 1 chunk +0 lines, -586 lines 0 comments Download
D src/utils/debugger/SkDrawCommand.cpp View 1 chunk +0 lines, -989 lines 0 comments Download
D src/utils/debugger/SkObjectParser.h View 1 chunk +0 lines, -134 lines 0 comments Download
D src/utils/debugger/SkObjectParser.cpp View 1 chunk +0 lines, -405 lines 0 comments Download
D src/utils/debugger/SkOverdrawMode.h View 1 chunk +0 lines, -25 lines 0 comments Download
D src/utils/debugger/SkOverdrawMode.cpp View 1 chunk +0 lines, -330 lines 0 comments Download
A + tools/debugger/SkDebugCanvas.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkDebugCanvas.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkDrawCommand.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkDrawCommand.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkObjectParser.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkObjectParser.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkOverdrawMode.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/debugger/SkOverdrawMode.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ethannicholas
Backstory: my last patch broke the cmake build, because the SkDebugCanvas is part of core ...
4 years, 10 months ago (2016-02-08 21:30:32 UTC) #3
joshualitt
On 2016/02/08 21:30:32, ethannicholas wrote: > Backstory: my last patch broke the cmake build, because ...
4 years, 10 months ago (2016-02-09 14:38:59 UTC) #4
jcgregorio
lgtm
4 years, 10 months ago (2016-02-09 19:40:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678893003/1
4 years, 10 months ago (2016-02-09 19:40:59 UTC) #7
hal.canary
no objections. lgtm
4 years, 10 months ago (2016-02-09 20:15:27 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:44:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3cb954245cecf262d740a83913681b9fe4b41555

Powered by Google App Engine
This is Rietveld 408576698