[turbofan] Introduce JSCreateLowering for optimizing JSCreate nodes.

[turbofan] Introduce JSCreateLowering for optimizing JSCreate nodes.

This moves the JSCreate related functionality from JSTypedLowering into
a dedicated JSCreateLowering reducer. This is in preparation of landing
the support for optimized literals in TurboFan, which would blow up
JSTypedLowering quite seriously otherwise.

R=mstarzinger@chromium.org

Committed: https://crrev.com/07e9921f5a5fc914b1f70f1903716c5e004d72ce
Cr-Commit-Position: refs/heads/master@{#33813}

[Benedikt Meurer, 2016-02-08 11:39:57]

Hey Michi,

Here's the refactoring we talked about before. No functional change here, just
moving stuff.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2016-02-08 12:10:41]

LGTM, just nits.

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/js-create-lowering-unittest.cc (right):

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
test/unittests/compiler/js-create-lowering-unittest.cc:57: Handle<JSArrayBuffer>
NewArrayBuffer(void* bytes, size_t byte_length) {
nit: This method is not used, let's drop it.

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/js-typed-lowering-unittest.cc (right):

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
test/unittests/compiler/js-typed-lowering-unittest.cc:95: Node*
FrameState(Handle<SharedFunctionInfo> shared, Node* outer_frame_state) {
nit: Is this method still being used within this file? If not, lets drop it.

[Benedikt Meurer, 2016-02-08 12:12:05]

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/js-create-lowering-unittest.cc (right):

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
test/unittests/compiler/js-create-lowering-unittest.cc:57: Handle<JSArrayBuffer>
NewArrayBuffer(void* bytes, size_t byte_length) {
On 2016/02/08 12:10:40, Michael Starzinger wrote:
> nit: This method is not used, let's drop it.

Done.

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
File test/unittests/compiler/js-typed-lowering-unittest.cc (right):

https://codereview.chromium.org/1678833002/diff/20001/test/unittests/compiler...
test/unittests/compiler/js-typed-lowering-unittest.cc:95: Node*
FrameState(Handle<SharedFunctionInfo> shared, Node* outer_frame_state) {
On 2016/02/08 12:10:40, Michael Starzinger wrote:
> nit: Is this method still being used within this file? If not, lets drop it.

Done.

[Benedikt Meurer, 2016-02-08 12:12:16]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-02-08 12:12:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1678833002/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-02-08 12:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678833002/40001

[commit-bot: I haz the power, 2016-02-08 12:33:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-08 12:34:05]

Description was changed from

==========
[turbofan] Introduce JSCreateLowering for optimizing JSCreate nodes.

This moves the JSCreate related functionality from JSTypedLowering into
a dedicated JSCreateLowering reducer. This is in preparation of landing
the support for optimized literals in TurboFan, which would blow up
JSTypedLowering quite seriously otherwise.

R=mstarzinger@chromium.org
==========

to

==========
[turbofan] Introduce JSCreateLowering for optimizing JSCreate nodes.

This moves the JSCreate related functionality from JSTypedLowering into
a dedicated JSCreateLowering reducer. This is in preparation of landing
the support for optimized literals in TurboFan, which would blow up
JSTypedLowering quite seriously otherwise.

R=mstarzinger@chromium.org

Committed: https://crrev.com/07e9921f5a5fc914b1f70f1903716c5e004d72ce
Cr-Commit-Position: refs/heads/master@{#33813}
==========

[commit-bot: I haz the power, 2016-02-08 12:34:05]

Patchset 3 (id:??) landed as
https://crrev.com/07e9921f5a5fc914b1f70f1903716c5e004d72ce
Cr-Commit-Position: refs/heads/master@{#33813}