Issue 1678693002: try -O1 to speed up msan bot

Issue 1678693002: try -O1 to speed up msan bot (Closed)

Created:
4 years, 10 months ago by mtklein_C

Modified:
4 years, 10 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

try -O1 to speed up msan bot We want it to be a debug build, but it probably doesn't need to be completely unoptimized. dm: 27m -> 7m nanobench: 140m -> 33m BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678693002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Committed: https://skia.googlesource.com/skia/+/a861c007fd5cc2de3691f8db8c653851a79eac4d

Patch Set 1 #

Patch Set 2 : Os #

Patch Set 3 : O1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	gyp/common_conditions.gypi	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 13 (10 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mtklein_C

Description was changed from ========== try -O2 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 14:59:33 UTC) #1

Description was changed from

==========
try -O2 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
==========

to

==========
try -O2 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

mtklein_C

Description was changed from ========== try -O2 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 15:00:06 UTC) #2

Description was changed from

==========
try -O2 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
try -Os to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

mtklein_C

Description was changed from ========== try -Os to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 15:00:31 UTC) #3

Description was changed from

==========
try -Os to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
try -Os to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

mtklein_C

Description was changed from ========== try -Os to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 15:12:13 UTC) #4

Description was changed from

==========
try -Os to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

mtklein_C

Description was changed from ========== try -O1 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 15:15:41 UTC) #5

Description was changed from

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench:

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

mtklein_C

Description was changed from ========== try -O1 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 15:16:07 UTC) #6

Description was changed from

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench:

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench: 140m ->

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

mtklein_C

Description was changed from ========== try -O1 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 16:48:33 UTC) #7

Description was changed from

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench: 140m ->

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench: 140m -> 33m

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

mtklein

mtklein@google.com changed reviewers: + mtklein@google.com

4 years, 10 months ago (2016-02-07 16:48:49 UTC) #8

mtklein@google.com changed reviewers:
+ mtklein@google.com

mtklein

The CQ bit was checked by mtklein@google.com

4 years, 10 months ago (2016-02-07 16:48:49 UTC) #9

The CQ bit was checked by mtklein@google.com

mtklein

lgtm

4 years, 10 months ago (2016-02-07 16:48:49 UTC) #10

lgtm

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678693002/40001

4 years, 10 months ago (2016-02-07 16:48:58 UTC) #11

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678693002/40001

commit-bot: I haz the power

Description was changed from ========== try -O1 to speed up msan bot We want it ...

4 years, 10 months ago (2016-02-07 17:12:37 UTC) #12

Message was sent while issue was closed.

Description was changed from

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench: 140m -> 33m

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
try -O1 to speed up msan bot

We want it to be a debug build, but it probably doesn't need to be
completely unoptimized.

dm: 27m -> 7m
nanobench: 140m -> 33m

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

Committed:
https://skia.googlesource.com/skia/+/a861c007fd5cc2de3691f8db8c653851a79eac4d
==========

commit-bot: I haz the power

Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/a861c007fd5cc2de3691f8db8c653851a79eac4d

4 years, 10 months ago (2016-02-07 17:12:38 UTC) #13

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a861c007fd5cc2de3691f8db8c653851a79eac4d

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages