Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1678663002: Revert of Change default Windows compiler to VS 2015 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, danakj, Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ ) Reason for revert: Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. Original issue's description: > Change default Windows compiler to VS 2015 > > The change to get_landmines.py is there because modifying this file > affects analyze behavior so that all tests run. Changing the printed > message is purely a side effect. > > This change also removes some redundant INCLUDE paths. These are > unnecessary when building with VS 2015 (because it defaults to the > Windows 10 SDK) and actively harmful (they make the INCLUDE path > problematically long). > > BUG=440500, 584782 > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > Cr-Commit-Position: refs/heads/master@{#373955} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500, 584782 Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 Cr-Commit-Position: refs/heads/master@{#374013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -6 lines 0 comments Download
M build/get_landmines.py View 1 chunk +3 lines, -1 line 0 comments Download
M build/toolchain/win/setup_toolchain.py View 1 chunk +12 lines, -10 lines 0 comments Download
M build/vs_toolchain.py View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Nico
Created Revert of Change default Windows compiler to VS 2015
4 years, 10 months ago (2016-02-06 06:28:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678663002/1
4 years, 10 months ago (2016-02-06 06:28:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 06:29:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 Cr-Commit-Position: refs/heads/master@{#374013}
4 years, 10 months ago (2016-02-06 06:29:52 UTC) #5
brucedawson
lgtm
4 years, 10 months ago (2016-02-06 07:38:24 UTC) #6
brucedawson
4 years, 10 months ago (2016-02-07 07:06:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1679693002/ by brucedawson@chromium.org.

The reason for reverting is: Issues that forced revert of VS 2015 as default
compiler are believed to be fixed..

Powered by Google App Engine
This is Rietveld 408576698