Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167863002: Update media galleries scan results, even when zero. (Closed)

Created:
6 years, 10 months ago by vandebo (ex-Chrome)
Modified:
6 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Update media galleries scan results, even when zero. Existing galleries that have scan results should get updated if the value stored in preferences is different than the value found - even if the value found is zero. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251828

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Patch Set 3 : fix up test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/media_scan_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/media_scan_manager_unittest.cc View 1 4 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vandebo (ex-Chrome)
6 years, 10 months ago (2014-02-14 22:57:41 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/167863002/diff/1/chrome/browser/media_galleries/media_scan_manager_unittest.cc File chrome/browser/media_galleries/media_scan_manager_unittest.cc (right): https://codereview.chromium.org/167863002/diff/1/chrome/browser/media_galleries/media_scan_manager_unittest.cc#newcode387 chrome/browser/media_galleries/media_scan_manager_unittest.cc:387: // Run once with no scan results. "uscan" ...
6 years, 10 months ago (2014-02-15 02:10:40 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/167863002/diff/1/chrome/browser/media_galleries/media_scan_manager_unittest.cc File chrome/browser/media_galleries/media_scan_manager_unittest.cc (right): https://codereview.chromium.org/167863002/diff/1/chrome/browser/media_galleries/media_scan_manager_unittest.cc#newcode387 chrome/browser/media_galleries/media_scan_manager_unittest.cc:387: // Run once with no scan results. "uscan" should ...
6 years, 10 months ago (2014-02-18 06:06:16 UTC) #3
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 06:06:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/167863002/100001
6 years, 10 months ago (2014-02-18 06:06:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 07:03:30 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=227970
6 years, 10 months ago (2014-02-18 07:03:32 UTC) #7
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 18:40:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/167863002/380001
6 years, 10 months ago (2014-02-18 18:41:10 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:42:39 UTC) #10
Message was sent while issue was closed. 
Change committed as 251828

Powered by Google App Engine
This is Rietveld 408576698