Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of size_t.

Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of size_t.

This is because size_t's size depends on the architecture and we send these structs over IPC. We need IPCs to match as we're now going to support 32 and 64 bit processes communicating on Android.

This is split off from https://codereview.chromium.org/1619363002/.

BUG=581409
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d2b0dced3c3f6875c3f35d7ebe2d5c448909b9d7
Cr-Commit-Position: refs/heads/master@{#374192}

[jam, 2016-02-06 01:05:47]

Description was changed from

==========
Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of
size_t.

This is because size_t's size depends on the architecture and we send these
structs over IPC. We need IPCs to match as we're now going to support 32 and 64
bit processes communicating on Android.

This is split off from https://codereview.chromium.org/1619363002/.

BUG=581409
==========

to

==========
Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of
size_t.

This is because size_t's size depends on the architecture and we send these
structs over IPC. We need IPCs to match as we're now going to support 32 and 64
bit processes communicating on Android.

This is split off from https://codereview.chromium.org/1619363002/.

BUG=581409
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jam, 2016-02-06 01:06:57]

jam@chromium.org changed reviewers:
+ enne@chromium.org, tsepez@chromium.org

[jam, 2016-02-06 01:06:58]

Tom: cc_messages.cc
Adrienne: rest

[Tom Sepez, 2016-02-08 17:32:09]

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages.cc
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages....
content/common/cc_messages.cc:190: for (std::size_t i = 0; i < p.size(); ++i) {
Should this get truncated, we'd write more items in this loop than we claimed. 
Either checked conversion, or index this loop via uint32_t and test against the
casted value.

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages....
content/common/cc_messages.cc:310: for (const auto& quad : p.quad_list) {
This has the same issue.

[jam, 2016-02-08 17:49:53]

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages.cc
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages....
content/common/cc_messages.cc:190: for (std::size_t i = 0; i < p.size(); ++i) {
On 2016/02/08 17:32:09, Tom Sepez wrote:
> Should this get truncated, we'd write more items in this loop than we claimed.

> Either checked conversion, or index this loop via uint32_t and test against
the
> casted value.

Done.

https://codereview.chromium.org/1678623002/diff/1/content/common/cc_messages....
content/common/cc_messages.cc:310: for (const auto& quad : p.quad_list) {
On 2016/02/08 17:32:09, Tom Sepez wrote:
> This has the same issue.

Done.

[Tom Sepez, 2016-02-08 18:05:33]

lgtm

[enne (OOO), 2016-02-08 18:39:26]

https://codereview.chromium.org/1678623002/diff/20001/content/common/cc_messa...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1678623002/diff/20001/content/common/cc_messa...
content/common/cc_messages.cc:683: WriteParam(m,
static_cast<uint32_t>(p.render_pass_list.size()));
Should these be checked_cast too?

[jam, 2016-02-08 18:43:44]

https://codereview.chromium.org/1678623002/diff/20001/content/common/cc_messa...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1678623002/diff/20001/content/common/cc_messa...
content/common/cc_messages.cc:683: WriteParam(m,
static_cast<uint32_t>(p.render_pass_list.size()));
On 2016/02/08 18:39:26, enne wrote:
> Should these be checked_cast too?

yeah, done

[enne (OOO), 2016-02-08 18:45:57]

lgtm

[jam, 2016-02-08 19:03:51]

The CQ bit was checked by jam@chromium.org

[jam, 2016-02-08 19:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1678623002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-02-08 19:10:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1678623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1678623002/40001

[commit-bot: I haz the power, 2016-02-08 21:52:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-08 21:53:48]

Description was changed from

==========
Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of
size_t.

This is because size_t's size depends on the architecture and we send these
structs over IPC. We need IPCs to match as we're now going to support 32 and 64
bit processes communicating on Android.

This is split off from https://codereview.chromium.org/1619363002/.

BUG=581409
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Switch cc::RenderPassId and cc::DrawQuad::Resources to use uint32_t instead of
size_t.

This is because size_t's size depends on the architecture and we send these
structs over IPC. We need IPCs to match as we're now going to support 32 and 64
bit processes communicating on Android.

This is split off from https://codereview.chromium.org/1619363002/.

BUG=581409
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d2b0dced3c3f6875c3f35d7ebe2d5c448909b9d7
Cr-Commit-Position: refs/heads/master@{#374192}
==========

[commit-bot: I haz the power, 2016-02-08 21:53:49]

Patchset 3 (id:??) landed as
https://crrev.com/d2b0dced3c3f6875c3f35d7ebe2d5c448909b9d7
Cr-Commit-Position: refs/heads/master@{#374192}