Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1678573002: Revert of [Contextual Search] Fixes flaky test. (Closed)

Created:
4 years, 10 months ago by pedro (no code reviews)
Modified:
4 years, 10 months ago
Reviewers:
Theresa, Donn Denman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Contextual Search] Fixes flaky test. (patchset #2 id:20001 of https://codereview.chromium.org/1669983003/ ) Reason for revert: Reverting it, since it's making some bots to crash. Original issue's description: > [Contextual Search] Fixes and re-enables > ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm. > > Sometimes, the test tries to check the search term before > the URL has started loading, which ends up resulting in > failing to match the search term. The empty URL could also > cause a crash when running the test, so this CL fixes the > problem by waiting for the URL to match the search term, > and also checks if the URL is null to prevent crashes. > > BUG=551711 > > Committed: https://crrev.com/938110aa31eef055669b539990d7f87336b57633 > Cr-Commit-Position: refs/heads/master@{#373889} TBR=twellington@chromium.org,donnd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551711 Committed: https://crrev.com/587347788a2e6a02b1a036ca49279fb3c6258b62 Cr-Commit-Position: refs/heads/master@{#373953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 5 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pedro (no code reviews)
Created Revert of [Contextual Search] Fixes flaky test.
4 years, 10 months ago (2016-02-05 23:45:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678573002/1
4 years, 10 months ago (2016-02-05 23:47:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 23:50:44 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 23:52:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587347788a2e6a02b1a036ca49279fb3c6258b62
Cr-Commit-Position: refs/heads/master@{#373953}

Powered by Google App Engine
This is Rietveld 408576698