Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1678463002: Parse additional microdump GPU line in the format: G GL_VERSION|GL_VENDOR|GL_RENDERER. (Closed)

Created:
4 years, 10 months ago by mmandlis
Modified:
4 years, 10 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parse additional line introduced in the microdump format and containing the GPU infromation in the following format: G GL_VERSION|GL_VENDOR|GL_RENDERER. The GPU version, vendor and renderer are extracted during microdump parsing and populated in the appropriate fields in the SystemInfo struct. This is to match the changes introduced in crrev.com/1343713002 and crrev.com/1334473003 BUG=chromium:536769 R=primiano@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/7b330814a4df1572fa4e6f8dc52647598a3f2f61

Patch Set 1 #

Patch Set 2 : synced to latest #

Patch Set 3 : Sync again #

Patch Set 4 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M src/google_breakpad/processor/system_info.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/processor/microdump.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/processor/microdump_processor_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/processor/stackwalk_common.cc View 1 2 3 3 chunks +21 lines, -0 lines 0 comments Download
M src/processor/testdata/microdump-arm.dmp View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk-arm.out View 1 chunk +4 lines, -0 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk-arm64.out View 1 chunk +2 lines, -0 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk.machine_readable-arm.out View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/testdata/microdump.stackwalk.machine_readable-arm64.out View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/testdata/minidump2.stackwalk.out View 1 chunk +2 lines, -0 lines 0 comments Download
M src/processor/testdata/minidump2.stackwalk.machine_readable.out View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mmandlis
4 years, 10 months ago (2016-02-05 21:32:59 UTC) #2
Primiano Tucci (use gerrit)
I feel like I have a dejavu :-) LGTM Please BUG=chromium:536769 and add a short ...
4 years, 10 months ago (2016-02-08 10:13:44 UTC) #3
mmandlis
On 2016/02/08 10:13:44, Primiano Tucci wrote: > I feel like I have a dejavu :-) ...
4 years, 10 months ago (2016-02-09 17:48:33 UTC) #5
mmandlis
4 years, 10 months ago (2016-02-11 18:04:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7b330814a4df1572fa4e6f8dc52647598a3f2f61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698