Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1678423003: Revert of Don't set the origin twice when navigating for javascript: URLs (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, loading-reviews_chromium.org, rwlbuis, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't set the origin twice when navigating for javascript: URLs (patchset #2 id:20001 of https://codereview.chromium.org/1670173002/ ) Reason for revert: Breaks scrolling in some Google Sheets: https://crbug.com/585091 Original issue's description: > Don't set the origin twice when navigating for javascript: URLs > > As javascript: navigations will end up with a document that has the > original document's URL, we shouldn't run the algorithm to determine > origin on the original URL, especially since we'll override the origin > later anyways. > > BUG=583445 > R=japhet@chromium.org,dcheng@chromium.org,mkwst@chromium.org > > Committed: https://crrev.com/75b27bda96f0fe77d40b502642d6669531981a49 > Cr-Commit-Position: refs/heads/master@{#373917} > > Committed: https://crrev.com/7fe934264200f6daf02881ceff76f578db0b6821 > Cr-Commit-Position: refs/heads/master@{#374023} TBR=japhet@chromium.org,mkwst@chromium.org,sigbjornf@opera.com,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=583445 Committed: https://crrev.com/f4b822554d2e9f895dcdfedeededd4706c894e12 Cr-Commit-Position: refs/heads/master@{#374298}

Patch Set 1 #

Messages

Total messages: 11 (1 generated)
dcheng
Created Revert of Don't set the origin twice when navigating for javascript: URLs
4 years, 10 months ago (2016-02-09 01:13:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 01:16:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 01:37:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 02:04:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 02:35:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 03:08:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 03:34:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678423003/1
4 years, 10 months ago (2016-02-09 04:04:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 04:26:42 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 04:28:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4b822554d2e9f895dcdfedeededd4706c894e12
Cr-Commit-Position: refs/heads/master@{#374298}

Powered by Google App Engine
This is Rietveld 408576698