Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1678353002: If the VM page fails to load, route to the VM connect page (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

If the VM page fails to load, route to the VM connect page Fixes #25707 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f2844d77b65e3eb14534f67e7e907cfd1169ba97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/observatory/lib/src/app/page.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 10 months ago (2016-02-09 15:39:31 UTC) #4
rmacnak
lgtm
4 years, 10 months ago (2016-02-09 19:13:10 UTC) #5
Cutch
4 years, 10 months ago (2016-02-09 20:21:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2844d77b65e3eb14534f67e7e907cfd1169ba97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698