Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1678343002: [Sync] Moving DataTypeState to proto for serialization (Closed)

Created:
4 years, 10 months ago by skym
Modified:
4 years, 10 months ago
Reviewers:
maxbogue, Gang Wu, pavely
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, albertb+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Moving DataTypeState to be a proto so that it can easily be serialized to storage by model types. BUG=543405 Committed: https://crrev.com/fe95d93a38c040091a6d8bcc55e2c66f29d4ce27 Cr-Commit-Position: refs/heads/master@{#374667}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Update for Pavel and merging with Max's changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -133 lines) Patch
M sync/api/metadata_batch.h View 2 chunks +5 lines, -4 lines 0 comments Download
M sync/api/metadata_batch.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/api/metadata_change_list.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/engine/model_type_worker.h View 3 chunks +3 lines, -2 lines 0 comments Download
M sync/engine/model_type_worker.cc View 8 chunks +16 lines, -14 lines 0 comments Download
M sync/engine/model_type_worker_unittest.cc View 12 chunks +19 lines, -17 lines 0 comments Download
M sync/internal_api/public/activation_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/public/model_type_processor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/internal_api/public/non_blocking_sync_common.h View 1 chunk +0 lines, -26 lines 0 comments Download
M sync/internal_api/public/non_blocking_sync_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M sync/internal_api/public/shared_model_type_processor.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M sync/internal_api/public/simple_metadata_change_list.h View 2 chunks +4 lines, -1 line 0 comments Download
M sync/internal_api/public/simple_metadata_change_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/test/fake_metadata_change_list.h View 3 chunks +5 lines, -2 lines 0 comments Download
M sync/internal_api/shared_model_type_processor.cc View 1 13 chunks +22 lines, -21 lines 0 comments Download
M sync/internal_api/shared_model_type_processor_unittest.cc View 1 8 chunks +12 lines, -11 lines 0 comments Download
M sync/internal_api/test/fake_metadata_change_list.cc View 1 chunk +1 line, -1 line 0 comments Download
A sync/protocol/data_type_state.proto View 1 1 chunk +34 lines, -0 lines 0 comments Download
M sync/protocol/protocol.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sync/sessions/model_type_registry_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M sync/test/engine/mock_model_type_processor.h View 5 chunks +11 lines, -8 lines 0 comments Download
M sync/test/engine/mock_model_type_processor.cc View 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
skym
PTAL
4 years, 10 months ago (2016-02-09 16:07:05 UTC) #4
pavely
lgtm https://codereview.chromium.org/1678343002/diff/20001/sync/protocol/data_type_state.proto File sync/protocol/data_type_state.proto (right): https://codereview.chromium.org/1678343002/diff/20001/sync/protocol/data_type_state.proto#newcode20 sync/protocol/data_type_state.proto:20: // request. May be updated by either by ...
4 years, 10 months ago (2016-02-10 00:21:21 UTC) #5
skym
Update for Pavel's comment. https://codereview.chromium.org/1678343002/diff/20001/sync/protocol/data_type_state.proto File sync/protocol/data_type_state.proto (right): https://codereview.chromium.org/1678343002/diff/20001/sync/protocol/data_type_state.proto#newcode20 sync/protocol/data_type_state.proto:20: // request. May be updated ...
4 years, 10 months ago (2016-02-10 15:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678343002/40001
4 years, 10 months ago (2016-02-10 15:19:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-10 16:13:35 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:14:46 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe95d93a38c040091a6d8bcc55e2c66f29d4ce27
Cr-Commit-Position: refs/heads/master@{#374667}

Powered by Google App Engine
This is Rietveld 408576698