Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1678333003: Revert of [mojo-edk] Simplify multiprocess pipe bootstrap (Closed)

Created:
4 years, 10 months ago by blundell
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo-edk] Simplify multiprocess pipe bootstrap (patchset #7 id:140001 of https://codereview.chromium.org/1675603002/ ) Reason for revert: This patch broke several browsertests on Linux: PlatformAppBrowserTest.LoadAndLaunchAppChromeRunning, PlatformAppBrowserTest.LoadAndLaunchAppWithFile, PolicyMakeDefaultBrowserTest.MakeDefaultDisabled (e.g., https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29%2832%29&number=25685). I could repro the failures locally, and reverting this patch fixed them. Example failure: PlatformAppBrowserTest.LoadAndLaunchAppChromeRunning (run #1): [ RUN ] PlatformAppBrowserTest.LoadAndLaunchAppChromeRunning <snip> [26865:26901:0209/004101:FATAL:thread.cc(270)] Check failed: GetThreadWasQuitProperly(). #0 0x0000f7142d94 base::debug::StackTrace::StackTrace() #1 0x0000f71a998f logging::LogMessage::~LogMessage() #2 0x0000f72cc94f base::Thread::ThreadMain() #3 0x0000f72b487a base::(anonymous namespace)::ThreadFunc() #4 0x0000e749dd4c start_thread #5 0x0000e6a7cb8e clone Original issue's description: > [mojo-edk] Simplify multiprocess pipe bootstrap > > This introduces a new MergePort message at the Ports layer > for joining two independent port cycles which each have > an unused (i.e. unwritten, unread, unsent) receiving port. > > MergePort allows us to create a MessagePipeDispatcher which > is immediately usable but which will eventually be linked to > a MessagePipeDispatcher on another port cycle, potentially in > another process. > > The basic idea is to create a fully functional port pair but > only bind one port to an MPD. Do this on each end and > merge the dangling ports asynchronously. > > The simplification here allows a lot of code to be deleted > from NodeController, some of which is deleted in this CL. > > Future work will convert existing bootstrap sites back to > using synchronous bootstrap, including the token-based APIs. > > BUG=584764 > TBR=ben@chromium.org for null check in mash shell > > Committed: https://crrev.com/b3ea203171e07f5c7e476e94d210ec4ad53ce5b0 > Cr-Commit-Position: refs/heads/master@{#374322} TBR=amistry@chromium.org,darin@chormium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584764 Committed: https://crrev.com/c8588be061339ced9a34d3d7e3319daf7eee241d Cr-Commit-Position: refs/heads/master@{#374346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -753 lines) Patch
M mash/shell/shell_application_delegate.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 4 chunks +7 lines, -27 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 chunk +6 lines, -14 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +16 lines, -9 lines 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +38 lines, -33 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +0 lines, -39 lines 0 comments Download
M mojo/edk/system/node_channel.h View 2 chunks +12 lines, -5 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 4 chunks +37 lines, -12 lines 0 comments Download
M mojo/edk/system/node_controller.h View 5 chunks +89 lines, -17 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 9 chunks +177 lines, -33 lines 0 comments Download
M mojo/edk/system/ports/event.h View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/edk/system/ports/message.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/edk/system/ports/name.h View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/edk/system/ports/node.h View 3 chunks +0 lines, -17 lines 0 comments Download
M mojo/edk/system/ports/node.cc View 4 chunks +28 lines, -153 lines 0 comments Download
M mojo/edk/system/ports/ports_unittest.cc View 2 chunks +22 lines, -318 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_bootstrap.h View 3 chunks +12 lines, -10 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_bootstrap.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M mojo/shell/runner/child/runner_connection.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/child_process.cc View 4 chunks +39 lines, -14 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 2 chunks +58 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 5 chunks +102 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
blundell
Created Revert of [mojo-edk] Simplify multiprocess pipe bootstrap
4 years, 10 months ago (2016-02-09 10:24:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678333003/1
4 years, 10 months ago (2016-02-09 10:25:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 10:27:03 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 10:28:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8588be061339ced9a34d3d7e3319daf7eee241d
Cr-Commit-Position: refs/heads/master@{#374346}

Powered by Google App Engine
This is Rietveld 408576698