Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1678303004: PlzNavigate: inform the renderer that a navigation is a POST (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index bb2156a285c74eaaef452b2e81c7f5b534d43756..6dacef306a298817a9a7e4f448b02da6e319f5bd 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -519,6 +519,9 @@ WebURLRequest CreateURLRequestForNavigation(
request.setHTTPReferrer(web_referrer, common_params.referrer.policy);
}
+ if (common_params.is_post)
+ request.setHTTPMethod(WebString::fromUTF8("POST"));
+
RequestExtraData* extra_data = new RequestExtraData();
extra_data->set_stream_override(std::move(stream_override));
request.setExtraData(extra_data);
@@ -593,7 +596,7 @@ CommonNavigationParams MakeCommonNavigationParams(
request->url(), referrer, extra_data->transition_type(),
FrameMsg_Navigate_Type::NORMAL, true, should_replace_current_entry,
ui_timestamp, report_type, GURL(), GURL(), LOFI_UNSPECIFIED,
- base::TimeTicks::Now());
+ base::TimeTicks::Now(), request->httpMethod().latin1() == "POST");
}
media::Context3D GetSharedMainThreadContext3D() {
@@ -5470,9 +5473,7 @@ void RenderFrameImpl::NavigateInternal(
}
}
- if (start_params.is_post && !browser_side_navigation) {
- request.setHTTPMethod(WebString::fromUTF8("POST"));
-
+ if (common_params.is_post && !browser_side_navigation) {
// Set post data.
WebHTTPBody http_body;
http_body.initialize();
@@ -5748,11 +5749,11 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request,
Send(new FrameHostMsg_BeginNavigation(
routing_id_,
MakeCommonNavigationParams(request, should_replace_current_entry),
- BeginNavigationParams(
- request->httpMethod().latin1(), GetWebURLRequestHeaders(*request),
- GetLoadFlagsForWebURLRequest(*request), request->hasUserGesture(),
- request->skipServiceWorker(),
- GetRequestContextTypeForWebURLRequest(*request)),
+ BeginNavigationParams(GetWebURLRequestHeaders(*request),
+ GetLoadFlagsForWebURLRequest(*request),
+ request->hasUserGesture(),
+ request->skipServiceWorker(),
+ GetRequestContextTypeForWebURLRequest(*request)),
GetRequestBodyForWebURLRequest(*request)));
}

Powered by Google App Engine
This is Rietveld 408576698