Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: content/common/navigation_params.cc

Issue 1678303004: PlzNavigate: inform the renderer that a navigation is a POST (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index f3e3ff173202c9b3014aa99b1eadeeef2d1a85e8..e9bff3845b5a9b22d7590d6299d235e496baf37e 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -29,8 +29,8 @@ CommonNavigationParams::CommonNavigationParams()
should_replace_current_entry(false),
report_type(FrameMsg_UILoadMetricsReportType::NO_REPORT),
lofi_state(LOFI_UNSPECIFIED),
- navigation_start(base::TimeTicks::Now()) {
-}
+ navigation_start(base::TimeTicks::Now()),
+ is_post(false) {}
CommonNavigationParams::CommonNavigationParams(
const GURL& url,
@@ -44,7 +44,8 @@ CommonNavigationParams::CommonNavigationParams(
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
LoFiState lofi_state,
- const base::TimeTicks& navigation_start)
+ const base::TimeTicks& navigation_start,
+ bool is_post)
: url(url),
referrer(referrer),
transition(transition),
@@ -56,8 +57,8 @@ CommonNavigationParams::CommonNavigationParams(
base_url_for_data_url(base_url_for_data_url),
history_url_for_data_url(history_url_for_data_url),
lofi_state(lofi_state),
- navigation_start(navigation_start) {
-}
+ navigation_start(navigation_start),
+ is_post(is_post) {}
CommonNavigationParams::~CommonNavigationParams() {
}
@@ -69,21 +70,19 @@ BeginNavigationParams::BeginNavigationParams()
request_context_type(REQUEST_CONTEXT_TYPE_LOCATION) {}
BeginNavigationParams::BeginNavigationParams(
- std::string method,
std::string headers,
int load_flags,
bool has_user_gesture,
bool skip_service_worker,
RequestContextType request_context_type)
- : method(method),
- headers(headers),
+ : headers(headers),
load_flags(load_flags),
has_user_gesture(has_user_gesture),
skip_service_worker(skip_service_worker),
request_context_type(request_context_type) {}
StartNavigationParams::StartNavigationParams()
- : is_post(false),
+ :
#if defined(OS_ANDROID)
has_user_gesture(false),
#endif
@@ -92,7 +91,6 @@ StartNavigationParams::StartNavigationParams()
}
StartNavigationParams::StartNavigationParams(
- bool is_post,
const std::string& extra_headers,
const std::vector<unsigned char>& browser_initiated_post_data,
#if defined(OS_ANDROID)
@@ -100,8 +98,7 @@ StartNavigationParams::StartNavigationParams(
#endif
int transferred_request_child_id,
int transferred_request_request_id)
- : is_post(is_post),
- extra_headers(extra_headers),
+ : extra_headers(extra_headers),
browser_initiated_post_data(browser_initiated_post_data),
#if defined(OS_ANDROID)
has_user_gesture(has_user_gesture),

Powered by Google App Engine
This is Rietveld 408576698