Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1678303004: PlzNavigate: inform the renderer that a navigation is a POST (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 3d98b5a8f0870286f52953175599cd482e73809d..86a1d6d1dc9836b22b757fc5a595480e14b7ffa7 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -539,6 +539,7 @@ TEST_F(RenderViewImplTest, OnNavigationHttpPost) {
common_params.url = GURL("data:text/html,<div>Page</div>");
common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
common_params.transition = ui::PAGE_TRANSITION_TYPED;
+ common_params.method = "POST";
request_params.page_id = -1;
// Set up post data.
@@ -546,7 +547,6 @@ TEST_F(RenderViewImplTest, OnNavigationHttpPost) {
"post \0\ndata");
const unsigned int length = 11;
const std::vector<unsigned char> post_data(raw_data, raw_data + length);
- start_params.is_post = true;
start_params.browser_initiated_post_data = post_data;
frame()->Navigate(common_params, start_params, request_params);
@@ -2497,15 +2497,14 @@ TEST_F(RenderViewImplTest, NavigationStartOverride) {
// days from now is *not* reported as one that starts in the future; as we
// sanitize the override allowing a maximum of ::Now().
CommonNavigationParams late_common_params;
- StartNavigationParams late_start_params;
late_common_params.url = GURL("data:text/html,<div>Another page</div>");
late_common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
late_common_params.transition = ui::PAGE_TRANSITION_TYPED;
late_common_params.navigation_start =
base::TimeTicks::Now() + base::TimeDelta::FromDays(42);
- late_start_params.is_post = true;
+ late_common_params.method = "POST";
- frame()->Navigate(late_common_params, late_start_params,
+ frame()->Navigate(late_common_params, StartNavigationParams(),
RequestNavigationParams());
ProcessPendingMessages();
base::Time after_navigation =
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698