Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: content/common/navigation_params.h

Issue 1678303004: PlzNavigate: inform the renderer that a navigation is a POST (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index d28882495be6873f90ca8ce8abe4a7e6fdc30c68..d2f83e756c13622554047902bcdc63d4c24c164b 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -59,7 +59,8 @@ struct CONTENT_EXPORT CommonNavigationParams {
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
LoFiState lofi_state,
- const base::TimeTicks& navigation_start);
+ const base::TimeTicks& navigation_start,
+ std::string method);
CommonNavigationParams(const CommonNavigationParams& other);
~CommonNavigationParams();
@@ -114,6 +115,9 @@ struct CONTENT_EXPORT CommonNavigationParams {
// PlzNavigate: For renderer initiated navigations, this will be set on the
// renderer side and sent with FrameHostMsg_BeginNavigation.
base::TimeTicks navigation_start;
+
+ // The request method: GET, POST, etc.
+ std::string method;
};
// Provided by the renderer ----------------------------------------------------
@@ -129,17 +133,13 @@ struct CONTENT_EXPORT BeginNavigationParams {
// TODO(clamy): See if it is possible to reuse this in
// ResourceMsg_Request_Params.
BeginNavigationParams();
- BeginNavigationParams(std::string method,
- std::string headers,
+ BeginNavigationParams(std::string headers,
int load_flags,
bool has_user_gesture,
bool skip_service_worker,
RequestContextType request_context_type);
BeginNavigationParams(const BeginNavigationParams& other);
- // The request method: GET, POST, etc.
- std::string method;
-
// Additional HTTP request headers.
std::string headers;
@@ -173,7 +173,6 @@ struct CONTENT_EXPORT BeginNavigationParams {
struct CONTENT_EXPORT StartNavigationParams {
StartNavigationParams();
StartNavigationParams(
- bool is_post,
const std::string& extra_headers,
const std::vector<unsigned char>& browser_initiated_post_data,
#if defined(OS_ANDROID)
@@ -184,9 +183,6 @@ struct CONTENT_EXPORT StartNavigationParams {
StartNavigationParams(const StartNavigationParams& other);
~StartNavigationParams();
- // Whether the navigation is a POST request (as opposed to a GET).
- bool is_post;
-
// Extra headers (separated by \n) to send during the request.
std::string extra_headers;
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698