PlzNavigate: inform the renderer that a navigation is a POST

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 3c1c77cd870b02898101dc1421c5c2b70d171889..8d64f905bc9fafeb1581dd5fada00bc4e9232dad 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -518,6 +518,8 @@ WebURLRequest CreateURLRequestForNavigation(
       request.setHTTPReferrer(web_referrer, common_params.referrer.policy);
   }
 
+  request.setHTTPMethod(WebString::fromUTF8(common_params.method));
+
   RequestExtraData* extra_data = new RequestExtraData();
   extra_data->set_stream_override(std::move(stream_override));
   extra_data->set_lofi_state(common_params.lofi_state);
@@ -593,7 +595,7 @@ CommonNavigationParams MakeCommonNavigationParams(
       request->url(), referrer, extra_data->transition_type(),
       FrameMsg_Navigate_Type::NORMAL, true, should_replace_current_entry,
       ui_timestamp, report_type, GURL(), GURL(), extra_data->lofi_state(),
-      base::TimeTicks::Now());
+      base::TimeTicks::Now(), request->httpMethod().latin1());
 }
 
 media::Context3D GetSharedMainThreadContext3D() {
@@ -5458,9 +5460,7 @@ void RenderFrameImpl::NavigateInternal(
       }
     }
 
-    if (start_params.is_post && !browser_side_navigation) {
-      request.setHTTPMethod(WebString::fromUTF8("POST"));

[Charlie Reis, 2016/02/17 21:52:06]

Sanity check: How does this happen now?  The CreateURLRequestForNavigation call
on line 5370?

[clamy, 2016/02/22 12:48:36]

Yes.

-
+    if (common_params.method == "POST" && !browser_side_navigation) {
       // Set post data.
       WebHTTPBody http_body;
       http_body.initialize();
@@ -5735,11 +5735,11 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request,
   Send(new FrameHostMsg_BeginNavigation(
       routing_id_,
       MakeCommonNavigationParams(request, should_replace_current_entry),
-      BeginNavigationParams(
-          request->httpMethod().latin1(), GetWebURLRequestHeaders(*request),
-          GetLoadFlagsForWebURLRequest(*request), request->hasUserGesture(),
-          request->skipServiceWorker(),
-          GetRequestContextTypeForWebURLRequest(*request)),
+      BeginNavigationParams(GetWebURLRequestHeaders(*request),
+                            GetLoadFlagsForWebURLRequest(*request),
+                            request->hasUserGesture(),
+                            request->skipServiceWorker(),
+                            GetRequestContextTypeForWebURLRequest(*request)),
       GetRequestBodyForWebURLRequest(*request)));
 }