Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1678293002: DM: this must have been missing from the previous CL (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein, scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: this must have been missing from the previous CL It'd be neat to have an Android trybot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1678293002 Committed: https://skia.googlesource.com/skia/+/fc57a3375eef897384a55fd85e95ba4394fbf67b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dm/DMSrcSinkAndroid.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mtklein
lgtm
4 years, 10 months ago (2016-02-08 21:23:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678293002/1
4 years, 10 months ago (2016-02-08 21:23:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fc57a3375eef897384a55fd85e95ba4394fbf67b
4 years, 10 months ago (2016-02-08 22:30:28 UTC) #7
scroggo
4 years, 10 months ago (2016-02-08 22:42:57 UTC) #9
Message was sent while issue was closed.
> DM: this must have been missing from the previous CL

Alas, no (fast) way for you to have discovered this (no way to build this file
without merging into Android*...)

>It'd be neat to have an Android trybot.

FWIW, we do have a bug filed at skbug.com/2606. Looking at my latest comment, I
think we haven't done it because it's hard, and we catch most problems in other
ways...

* Now that HWUI can be built as its own library though, I could imagine that we
could test some of this without waiting to merge into Android?

Powered by Google App Engine
This is Rietveld 408576698