Split out instrumentation test name map for further use.

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import string
 
 
 class Test(object):
   """
@@ skipping 1488 matching lines @@
     mock_test_results = {
       'per_iteration_data': [{'TestA': [{'status': 'SUCCESS'}]},
                              {'TestB': [{'status': 'FAILURE'}]}]
     }
     api.chromium_android.run_java_unit_test_suite(
         self.name, verbose=True, suffix=suffix,
         json_results_file=json_results_file,
         step_test_data=lambda: api.json.test_api.output(mock_test_results))
 
 
+ANDROID_INSTRUMENTATION_TARGET_MAP = {
+    'AndroidWebViewTest': 'android_webview_test_apk',
+    'ChromePublicTest': 'chrome_public_test_apk',
+    'ChromeSyncShellTest': 'chrome_sync_shell_test_apk',
+    'ChromotingTest': 'remoting_test_apk',
+    'ContentShellTest': 'content_shell_test_apk',
+    'MojoTest': 'mojo_test_apk',
+    'SystemWebViewShellLayoutTest': 'system_webview_shell_layout_test_apk',
+}
+
+
 class AndroidInstrumentationTest(AndroidTest):
   _DEFAULT_SUITES = {
     'AndroidWebViewTest': {
-      'compile_targets': ['android_webview_test_apk'],
       'isolate_file_path': 'android_webview/android_webview_test_apk.isolate',
       'apk_under_test': 'AndroidWebView.apk',
       'test_apk': 'AndroidWebViewTest.apk',
     },
     'ChromePublicTest': {
-      'compile_targets': ['chrome_public_test_apk'],
       'isolate_file_path': 'chrome/chrome_public_test_apk.isolate',
       'apk_under_test': 'ChromePublic.apk',
       'test_apk': 'ChromePublicTest.apk',
       'additional_apks': [
         'ChromePublicTestSupport.apk',
         'ChromiumNetTestSupport.apk',
       ],
     },
     'ChromeSyncShellTest': {
-      'compile_targets': ['chrome_sync_shell_test_apk'],
       'isolate_file_path': None,
       'apk_under_test': 'ChromeSyncShell.apk',
       'test_apk': 'ChromeSyncShellTest.apk',
     },
     'ChromotingTest': {
-      'compile_targets': ['remoting_test_apk'],
       'isolate_file_path': None,
       'apk_under_test': 'Chromoting.apk',
       'test_apk': 'ChromotingTest.apk',
     },
     'ContentShellTest': {
-      'compile_targets': ['content_shell_test_apk'],
       'isolate_file_path': 'content/content_shell_test_apk.isolate',
       'apk_under_test': 'ContentShell.apk',
       'test_apk': 'ContentShellTest.apk',
     },
     'SystemWebViewShellLayoutTest': {
-      'compile_targets': ['system_webview_apk',
-                          'system_webview_shell_apk',
-                          'system_webview_shell_layout_test_apk',
-                          'android_tools'],
+      'extra_compile_targets': ['system_webview_apk',

[bpastene, 2016/02/09 07:04:21]

What makes these 'extra'? What's the point of designating one of them as the
'main' compile target?

+                                'system_webview_shell_apk',
+                                'android_tools'],
       'isolate_file_path': ('android_webview/'
                             'system_webview_shell_test_apk.isolate'),
       'apk_under_test': 'SystemWebViewShell.apk',
       'test_apk': 'SystemWebViewShellLayoutTest.apk',
       'additional_apks': ['SystemWebView.apk'],
     },
     'MojoTest': {
-      'compile_targets': ['mojo_test_apk'],
       'isolate_file_path': None,
       'apk_under_test': None,
       'test_apk': 'MojoTest.apk',
     }
   }
 
   def __init__(self, name, compile_targets=None, apk_under_test=None,
                test_apk=None, isolate_file_path=None, timeout_scale=None,
                flakiness_dashboard='test-results.appspot.com',
                annotation=None, except_annotation=None, screenshot=False,
                verbose=True, tool=None, host_driven_root=None,
                additional_apks=None):
     suite_defaults = AndroidInstrumentationTest._DEFAULT_SUITES.get(name, {})
+    if not compile_targets:
+      compile_targets = []
+      main_target = ANDROID_INSTRUMENTATION_TARGET_MAP.get(name)
+      if main_target:
+        compile_targets.append(main_target)
+      compile_targets.extend(suite_defaults.get('extra_compile_targets', []))
+
     super(AndroidInstrumentationTest, self).__init__(
         name,
-        compile_targets or suite_defaults.get('compile_targets'),
+        compile_targets,
         isolate_file_path or suite_defaults.get('isolate_file_path'))
     self._additional_apks = (
         additional_apks or suite_defaults.get('additional_apks'))
     self._annotation = annotation
     self._apk_under_test = (
         apk_under_test or suite_defaults.get('apk_under_test'))
     self._except_annotation = except_annotation
     self._flakiness_dashboard = flakiness_dashboard
     self._host_driven_root = host_driven_root
     self._screenshot = screenshot
@@ skipping 211 matching lines @@
   def run(self, api, suffix, test_filter=None):
     api.chromium_android.coverage_report(upload=False)
     api.chromium_android.get_changed_lines_for_revision()
     api.chromium_android.incremental_coverage_report()
 
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]