Don't focus the location bar in a phishy situation.

chrome/browser/ui/browser_navigator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_navigator_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/location_bar/location_bar.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
+#include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/omnibox/browser/omnibox_view.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 using content::WebContents;
 
 namespace {
 
 const char kExpectedTitle[] = "PASSED!";
 const char kEchoTitleCommand[] = "/echotitle";
 
 GURL GetGoogleURL() {
@@ skipping 1367 matching lines @@
   EXPECT_TRUE(params.target_contents);
   EXPECT_EQ(expected_title, params.target_contents->GetTitle());
   // GURL always keeps non-ASCII characters escaped, but check them anyways.
   EXPECT_EQ(GURL(expected_url).spec(), params.target_contents->GetURL().spec());
   // Check the omnibox text. It should have escaped RTL with unescaped text.
   LocationBar* location_bar = browser()->window()->GetLocationBar();
   OmniboxView* omnibox_view = location_bar->GetOmniboxView();
   EXPECT_EQ(base::UTF8ToUTF16(expected_url), omnibox_view->GetText());
 }
 
+// Ensure that crbug.com/567445 does not regress.
+IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, AboutBlankNavigationLocationTest) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+
+  ui_test_utils::NavigateToURL(browser(),
+                               embedded_test_server()->GetURL("/title1.html"));
+
+  const char kSpoofScript[] =
+      "var w = window.open('about:blank');"
+      "w.opener = null;"
+      "w.document.location = '%s';";
+
+  TabStripModel* tab_strip = browser()->tab_strip_model();
+  WebContents* web_contents = tab_strip->GetActiveWebContents();
+
+  ASSERT_TRUE(content::ExecuteScript(
+      web_contents,
+      base::StringPrintf(
+          kSpoofScript,
+          embedded_test_server()->GetURL("/title2.html").spec().c_str())));
+  EXPECT_FALSE(web_contents->GetController().GetPendingEntry());
+  EXPECT_EQ(embedded_test_server()->GetURL("/title1.html"),
+            web_contents->GetVisibleURL());
+
+  LocationBar* location_bar = browser()->window()->GetLocationBar();
+  OmniboxView* omnibox = location_bar->GetOmniboxView();
+  ASSERT_FALSE(omnibox->IsEditingOrEmpty());

[palmer, 2016/02/12 01:15:54]

This test passes, but I'm not 100% sure it's testing the right thing. Any clues?

[Peter Kasting, 2016/02/12 01:37:20]

It's not.  Just focusing the omnibox does not set the state to editing.

+  // ASSERT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));

[palmer, 2016/02/12 01:15:54]

This line causes the link to fail: No implementation available for the function
ui_test_utils::IsViewFocused. I'm not sure why. Any clues?

[Peter Kasting, 2016/02/12 01:37:20]

That's linked into the interactive_ui_tests target, whereas this is linked into
browser_tests.

+}
+
 }  // namespace