Don't focus the location bar in a phishy situation.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 2897 matching lines @@
   // TODO(brettw): It seems bogus to reach into here and initialize the host.
   if (is_resume_pending_) {
     is_resume_pending_ = false;
     GetRenderViewHost()->GetWidget()->Init();
     GetMainFrame()->Init();
   }
 }
 
 bool WebContentsImpl::FocusLocationBarByDefault() {
   NavigationEntry* entry = controller_.GetVisibleEntry();
-  if (entry && entry->GetURL() == GURL(url::kAboutBlankURL))
+  if (entry &&
+      entry->GetTransitionType() != ui::PageTransition::PAGE_TRANSITION_LINK &&
+      entry->GetURL() == GURL(url::kAboutBlankURL)) {

[Charlie Reis, 2016/02/10 05:47:48]

Here's what I would recommend (if we decide to keep the focus-about-blank logic
for startup):

// If we are starting at about:blank, give the omnibox focus to let the user
easily edit it.  We intentionally check the pending entry rather than the
visible one, since we don't want to be tricked by non-visible pending URLs.  See
https://crbug.com/567445.
NavigationEntryImpl* entry = controller_.GetPendingEntry();
if (controller_.IsInitialNavigation() &&
    entry && !entry->is_renderer_initiated() &&
    entry->GetURL() == GURL(url::kAboutBlankURL)) {
...

[palmer, 2016/02/10 23:15:25]

OK, I did that, and added a sketch of a test that tests nothing. :) Do you have
any clues about how I can make a test that does do something? Do I need to
migrate it to chrome browsertests, or is there some vestigial LocationBar in
content/ (doesn't look like it)?

     return true;
+  }
   return delegate_ && delegate_->ShouldFocusLocationBarByDefault(this);
 }
 
 void WebContentsImpl::SetFocusToLocationBar(bool select_all) {
   if (delegate_)
     delegate_->SetFocusToLocationBar(select_all);
 }
 
 void WebContentsImpl::DidStartNavigation(NavigationHandle* navigation_handle) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
@@ skipping 1822 matching lines @@
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStartedPlaying(id));
 }
 
 void WebContentsImpl::MediaStoppedPlaying(
     const WebContentsObserver::MediaPlayerId& id) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, MediaStoppedPlaying(id));
 }
 
 }  // namespace content