Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1678183003: Call QuitNow instead of exit(0) to kill GPU process. (Closed)

Created:
4 years, 10 months ago by jbauman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call QuitNow instead of exit(0) to kill GPU process. This was causing a crash because the global object destructors were being called while other threads were running. BUG=567808 Committed: https://crrev.com/e846a86900127799b21f78ba4451e6b584d4c25b Cr-Commit-Position: refs/heads/master@{#374582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbauman
4 years, 10 months ago (2016-02-10 00:44:20 UTC) #2
Ken Russell (switch to Gerrit)
LGTM, though I wonder if this could cause situations where the GPU process may not ...
4 years, 10 months ago (2016-02-10 01:11:43 UTC) #3
piman
This LGTM. If this causes problems, we can use _exit, that skips the global destructors, ...
4 years, 10 months ago (2016-02-10 01:19:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678183003/1
4 years, 10 months ago (2016-02-10 01:24:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 02:41:00 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 02:42:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e846a86900127799b21f78ba4451e6b584d4c25b
Cr-Commit-Position: refs/heads/master@{#374582}

Powered by Google App Engine
This is Rietveld 408576698