Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1678143002: Stage --harmony-species flag, enabling Symbol.species (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage --harmony-species flag, enabling Symbol.species This patch moves Symbol.species support to the "experimental JavaScript features" flag. While @@species is still a performance hit, it doesn't seem like it would make the web unusably slow; shipping would still have to wait on fixing the performance regression, but staging this version should yield valuable web compatibility information. R=cbruni BUG=v8:4093 LOG=Y Committed: https://crrev.com/43cd128eff9ec9bf6644f3163fdb779815876e80 Cr-Commit-Position: refs/heads/master@{#33827}

Patch Set 1 #

Patch Set 2 : Disable an ignition test using subclassing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -43 lines) Patch
M src/flag-definitions.h View 1 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 3 chunks +2 lines, -42 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678143002/1
4 years, 10 months ago (2016-02-08 15:45:14 UTC) #2
Dan Ehrenberg
4 years, 10 months ago (2016-02-08 15:45:32 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15030)
4 years, 10 months ago (2016-02-08 16:03:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678143002/20001
4 years, 10 months ago (2016-02-08 16:11:38 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 16:34:15 UTC) #9
Camillo Bruni
LGTM as discussed offline, this should be fine as long as we don't annoy our ...
4 years, 10 months ago (2016-02-08 17:53:15 UTC) #10
Michael Hablich
On 2016/02/08 17:53:15, cbruni wrote: > LGTM > as discussed offline, this should be fine ...
4 years, 10 months ago (2016-02-08 18:08:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678143002/20001
4 years, 10 months ago (2016-02-08 21:15:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-08 21:17:39 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 21:18:24 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43cd128eff9ec9bf6644f3163fdb779815876e80
Cr-Commit-Position: refs/heads/master@{#33827}

Powered by Google App Engine
This is Rietveld 408576698