Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1678123002: Extend subarray web compatibility fix to --harmony-species (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extend subarray web compatibility fix to --harmony-species ES2016 TypedArray subclassing semantics break the Node.js Buffer module, also used on the web. I wrote a pull request against the web and Node versions to fix the issue, but the pull request has not yet been granted, and this is blocking shipping the change. For now, this patch extends the web compatibility workaround to the --harmony-species flag, so that Symbol.species and associated subclassing semantics can ship independently. R=cbruni BUG=v8:4665 LOG=Y Committed: https://crrev.com/e1de522afab0b9c13867f78ad6ad299ee8c0c8ac Cr-Commit-Position: refs/heads/master@{#33826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/js/typedarray.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-4665-2.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678123002/1
4 years, 10 months ago (2016-02-08 15:20:51 UTC) #2
Dan Ehrenberg
4 years, 10 months ago (2016-02-08 15:39:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 15:41:48 UTC) #5
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-08 17:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678123002/1
4 years, 10 months ago (2016-02-08 21:14:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 21:16:33 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 21:17:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1de522afab0b9c13867f78ad6ad299ee8c0c8ac
Cr-Commit-Position: refs/heads/master@{#33826}

Powered by Google App Engine
This is Rietveld 408576698