Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1678103007: [Chromecast] Set use_alsa=true by default on Chromecast platforms. (Closed)

Created:
4 years, 10 months ago by slan
Modified:
4 years, 10 months ago
Reviewers:
halliwell, DaleCurtis, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Set use_alsa=true by default on Chromecast platforms. Chromecast code depends on media:: alsa code, so enable it by default. use_pulseaudio will continue to be false when is_chromecast=true. BUG= b/27105215 TEST= Builds on several Cast platforms. Committed: https://crrev.com/09f6c021d48dd68fc24f4c1d4a1061a5564ea171 Cr-Commit-Position: refs/heads/master@{#374780}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M media/media.gyp View 1 chunk +2 lines, -2 lines 2 comments Download
M media/media_options.gni View 1 chunk +5 lines, -5 lines 0 comments Download
M media/midi/midi.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
slan
4 years, 10 months ago (2016-02-10 00:04:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678103007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678103007/1
4 years, 10 months ago (2016-02-10 00:06:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 01:42:51 UTC) #9
alokp
lgtm https://codereview.chromium.org/1678103007/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/1678103007/diff/1/media/media.gyp#newcode16 media/media.gyp:16: ['(OS=="linux" or OS=="freebsd" or OS=="solaris") and (embedded==0 or ...
4 years, 10 months ago (2016-02-10 06:03:13 UTC) #10
slan
https://codereview.chromium.org/1678103007/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/1678103007/diff/1/media/media.gyp#newcode16 media/media.gyp:16: ['(OS=="linux" or OS=="freebsd" or OS=="solaris") and (embedded==0 or chromecast==1)', ...
4 years, 10 months ago (2016-02-10 16:05:23 UTC) #11
DaleCurtis
lgtm
4 years, 10 months ago (2016-02-10 23:13:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678103007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678103007/1
4 years, 10 months ago (2016-02-10 23:28:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 23:37:26 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09f6c021d48dd68fc24f4c1d4a1061a5564ea171
Cr-Commit-Position: refs/heads/master@{#374780}

Powered by Google App Engine
This is Rietveld 408576698