[interpreter] Thread through language mode some more.

src/compiler/bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-graph-builder.h"
 
 #include "src/compiler/bytecode-branch-analysis.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/operator-properties.h"
 #include "src/interpreter/bytecodes.h"
@@ skipping 650 matching lines @@
       Handle<Name>::cast(bytecode_iterator().GetConstantForIndexOperand(0));
   VectorSlotPair feedback =
       CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(1));
 
   const Operator* op = javascript()->LoadGlobal(name, feedback, typeof_mode);
   Node* node = NewNode(op, BuildLoadFeedbackVector());
   environment()->BindAccumulator(node, &states);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalSloppy() {
-  DCHECK(is_sloppy(language_mode()));
   BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalStrict() {
-  DCHECK(is_strict(language_mode()));
   BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofSloppy() {
-  DCHECK(is_sloppy(language_mode()));
   BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofStrict() {
-  DCHECK(is_strict(language_mode()));
   BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalSloppyWide() {
-  DCHECK(is_sloppy(language_mode()));
   BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalStrictWide() {
-  DCHECK(is_strict(language_mode()));
   BuildLoadGlobal(TypeofMode::NOT_INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofSloppyWide() {
-  DCHECK(is_sloppy(language_mode()));
   BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
 }
 
 void BytecodeGraphBuilder::VisitLdaGlobalInsideTypeofStrictWide() {
-  DCHECK(is_strict(language_mode()));
   BuildLoadGlobal(TypeofMode::INSIDE_TYPEOF);
 }
 
-void BytecodeGraphBuilder::BuildStoreGlobal() {
+void BytecodeGraphBuilder::BuildStoreGlobal(LanguageMode language_mode) {
   FrameStateBeforeAndAfter states(this);
   Handle<Name> name =
       Handle<Name>::cast(bytecode_iterator().GetConstantForIndexOperand(0));
   VectorSlotPair feedback =
       CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(1));
   Node* value = environment()->LookupAccumulator();
 
-  const Operator* op =
-      javascript()->StoreGlobal(language_mode(), name, feedback);
+  const Operator* op = javascript()->StoreGlobal(language_mode, name, feedback);
   Node* node = NewNode(op, value, BuildLoadFeedbackVector());
   environment()->RecordAfterState(node, &states);
 }
 
 void BytecodeGraphBuilder::VisitStaGlobalSloppy() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildStoreGlobal();
+  BuildStoreGlobal(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitStaGlobalStrict() {
-  DCHECK(is_strict(language_mode()));
-  BuildStoreGlobal();
+  BuildStoreGlobal(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitStaGlobalSloppyWide() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildStoreGlobal();
+  BuildStoreGlobal(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitStaGlobalStrictWide() {
-  DCHECK(is_strict(language_mode()));
-  BuildStoreGlobal();
+  BuildStoreGlobal(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitLdaContextSlot() {
   // TODO(mythria): LoadContextSlots are unrolled by the required depth when
   // generating bytecode. Hence the value of depth is always 0. Update this
   // code, when the implementation changes.
   // TODO(mythria): immutable flag is also set to false. This information is not
   // available in bytecode array. update this code when the implementation
   // changes.
   const Operator* op = javascript()->LoadContext(
@@ skipping 131 matching lines @@
 void BytecodeGraphBuilder::VisitKeyedLoadICSloppyWide() {
   DCHECK(is_sloppy(language_mode()));
   BuildKeyedLoad();
 }
 
 void BytecodeGraphBuilder::VisitKeyedLoadICStrictWide() {
   DCHECK(is_strict(language_mode()));
   BuildKeyedLoad();
 }
 
-void BytecodeGraphBuilder::BuildNamedStore() {
+void BytecodeGraphBuilder::BuildNamedStore(LanguageMode language_mode) {
   FrameStateBeforeAndAfter states(this);
   Node* value = environment()->LookupAccumulator();
   Node* object =
       environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
   Handle<Name> name =
       Handle<Name>::cast(bytecode_iterator().GetConstantForIndexOperand(1));
   VectorSlotPair feedback =
       CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(2));
 
-  const Operator* op =
-      javascript()->StoreNamed(language_mode(), name, feedback);
+  const Operator* op = javascript()->StoreNamed(language_mode, name, feedback);
   Node* node = NewNode(op, object, value, BuildLoadFeedbackVector());
   environment()->RecordAfterState(node, &states);
 }
 
 void BytecodeGraphBuilder::VisitStoreICSloppy() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildNamedStore();
+  BuildNamedStore(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitStoreICStrict() {
-  DCHECK(is_strict(language_mode()));
-  BuildNamedStore();
+  BuildNamedStore(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitStoreICSloppyWide() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildNamedStore();
+  BuildNamedStore(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitStoreICStrictWide() {
-  DCHECK(is_strict(language_mode()));
-  BuildNamedStore();
+  BuildNamedStore(LanguageMode::STRICT);
 }
 
-void BytecodeGraphBuilder::BuildKeyedStore() {
+void BytecodeGraphBuilder::BuildKeyedStore(LanguageMode language_mode) {
   FrameStateBeforeAndAfter states(this);
   Node* value = environment()->LookupAccumulator();
   Node* object =
       environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
   Node* key =
       environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(1));
   VectorSlotPair feedback =
       CreateVectorSlotPair(bytecode_iterator().GetIndexOperand(2));
 
-  const Operator* op = javascript()->StoreProperty(language_mode(), feedback);
+  const Operator* op = javascript()->StoreProperty(language_mode, feedback);
   Node* node = NewNode(op, object, key, value, BuildLoadFeedbackVector());
   environment()->RecordAfterState(node, &states);
 }
 
 void BytecodeGraphBuilder::VisitKeyedStoreICSloppy() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildKeyedStore();
+  BuildKeyedStore(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitKeyedStoreICStrict() {
-  DCHECK(is_strict(language_mode()));
-  BuildKeyedStore();
+  BuildKeyedStore(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitKeyedStoreICSloppyWide() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildKeyedStore();
+  BuildKeyedStore(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitKeyedStoreICStrictWide() {
-  DCHECK(is_strict(language_mode()));
-  BuildKeyedStore();
+  BuildKeyedStore(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitPushContext() {
   Node* new_context = environment()->LookupAccumulator();
   environment()->BindRegister(bytecode_iterator().GetRegisterOperand(0),
                               environment()->Context());
   environment()->SetContext(new_context);
 }
 
 void BytecodeGraphBuilder::VisitPopContext() {
@@ skipping 349 matching lines @@
                        jsgraph()->FalseConstant(), jsgraph()->TrueConstant());
   environment()->BindAccumulator(node);
 }
 
 void BytecodeGraphBuilder::VisitTypeOf() {
   Node* node =
       NewNode(javascript()->TypeOf(), environment()->LookupAccumulator());
   environment()->BindAccumulator(node);
 }
 
-void BytecodeGraphBuilder::BuildDelete() {
+void BytecodeGraphBuilder::BuildDelete(LanguageMode language_mode) {
   FrameStateBeforeAndAfter states(this);
   Node* key = environment()->LookupAccumulator();
   Node* object =
       environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
   Node* node =
-      NewNode(javascript()->DeleteProperty(language_mode()), object, key);
+      NewNode(javascript()->DeleteProperty(language_mode), object, key);
   environment()->BindAccumulator(node, &states);
 }
 
 void BytecodeGraphBuilder::VisitDeletePropertyStrict() {
-  DCHECK(is_strict(language_mode()));
-  BuildDelete();
+  BuildDelete(LanguageMode::STRICT);
 }
 
 void BytecodeGraphBuilder::VisitDeletePropertySloppy() {
-  DCHECK(is_sloppy(language_mode()));
-  BuildDelete();
+  BuildDelete(LanguageMode::SLOPPY);
 }
 
 void BytecodeGraphBuilder::VisitDeleteLookupSlot() {
   FrameStateBeforeAndAfter states(this);
   Node* name = environment()->LookupAccumulator();
   const Operator* op = javascript()->CallRuntime(Runtime::kDeleteLookupSlot);
   Node* result = NewNode(op, environment()->Context(), name);
   environment()->BindAccumulator(result, &states);
 }
 
@@ skipping 478 matching lines @@
     // Phi does not exist yet, introduce one.
     value = NewPhi(inputs, value, control);
     value->ReplaceInput(inputs - 1, other);
   }
   return value;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8