Vibration API: plumbing from Blink to Java.

content/browser/renderer_host/render_process_host_impl.cc

Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index ecd4139d42d3e8efd3941311dd8cdde8d3e41bb6..44364df237ea4e7af237355718f7cfda55f04a99 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -91,6 +91,8 @@
 #include "content/browser/speech/speech_recognition_dispatcher_host.h"
 #include "content/browser/storage_partition_impl.h"
 #include "content/browser/tracing/trace_message_filter.h"
+#include "content/browser/vibration/vibration_browser_message_filter.h"
+#include "content/browser/vibration/vibration_service_factory.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/browser/worker_host/worker_message_filter.h"
 #include "content/browser/worker_host/worker_storage_partition.h"
@@ -710,6 +712,7 @@ void RenderProcessHostImpl::CreateMessageFilters() {
       switches::kEnableMemoryBenchmarking))
     channel_->AddFilter(new MemoryBenchmarkMessageFilter());
 #endif
+  channel_->AddFilter(new VibrationBrowserMessageFilter(NewVibrationService()));

[Peter Beverloo, 2013/06/13 11:27:45]

It seems odd for the message filter to own the vibration service.  Is this a
common practice?  Looking at the calls above, it isn't.  It'd be good to know
how, for example, the Gamepad message filter does this.

[Michael van Ouwerkerk, 2013/06/18 14:39:23]

Most of the above code gets the dependencies from storage_partition_impl_. I
don't think VibrationService belongs there. I don't see anything particularly
wrong with VibrationBrowserMessageFilter owning the service, nothing else needs
to access it so the ownership makes sense. Weaker alternatives:
* the filter instantiates the service, does not receive it in its constructor
* the service is a singleton and provides and owns an instance

 }
 
 int RenderProcessHostImpl::GetNextRoutingID() {