content/browser/vibration/vibration_service.cc - Issue 16781002: Vibration API: plumbing from Blink to Java.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/vibration/vibration_service.cc

Issue 16781002: Vibration API: plumbing from Blink to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/vibration/vibration_service.h"

	6

	7 #include "build/build_config.h"

	8 #if defined(OS_ANDROID)

	9 #include "content/browser/vibration/vibration_service_impl_android.h"

	10 #endif

	11

	12 namespace content {

	13

	14 // static

	15 VibrationService* VibrationService::Create() {

	16 #if defined(OS_ANDROID)
	bulach 2013/06/20 14:21:04 probably better to #if !defined(OS_ANDROID) the wh probably better to #if !defined(OS_ANDROID) the whole function, remove from 8-10, and then just have this implementation in the android itself. Michael van Ouwerkerk 2013/06/20 17:34:09 Done. Show quoted text On 2013/06/20 14:21:04, bulach wrote: > probably better to #if !defined(OS_ANDROID) the whole function, remove from > 8-10, and then just have this implementation in the android itself. Done.
	17 return new VibrationServiceImplAndroid();

	18 #endif

	19 return 0;

	20 }

	21

	22 } // namespace content

OLD	NEW