Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Side by Side Diff: content/browser/vibration/vibration_message_filter.h

Issue 16781002: Vibration API: plumbing from Blink to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_VIBRATION_VIBRATION_MESSAGE_FILTER_H_
bulach 2013/06/20 14:21:04 nit: CONTENT_BROWSER_...
Michael van Ouwerkerk 2013/06/20 17:34:09 Done.
6 #define CONTENT_VIBRATION_VIBRATION_MESSAGE_FILTER_H_
7
8 #include "base/memory/scoped_ptr.h"
9 #include "content/browser/vibration/vibration_service.h"
10 #include "content/public/browser/browser_message_filter.h"
11
12 namespace content {
13
14 class VibrationMessageFilter : public BrowserMessageFilter {
15 public:
16 VibrationMessageFilter(VibrationService* vibration_service);
bulach 2013/06/20 14:21:04 nit: explicit. also, since this is taking ownershi
Michael van Ouwerkerk 2013/06/20 17:34:09 Done.
17
18 // BrowserMessageFilter implementation.
19 virtual bool OnMessageReceived(const IPC::Message& message,
20 bool* message_was_ok) OVERRIDE;
21
22 private:
23 virtual ~VibrationMessageFilter();
24
25 void OnVibrate(unsigned milliseconds);
bulach 2013/06/20 14:21:04 int?
Michael van Ouwerkerk 2013/06/20 17:34:09 Like in the other comment... could you explain why
26 void OnCancelVibration();
27
28 scoped_ptr<VibrationService> vibration_service_;
29 };
30
31 } // namespace content
32
33 #endif // CONTENT_VIBRATION_VIBRATION_MESSAGE_FILTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698