content/browser/vibration/vibration_service_factory.h - Issue 16781002: Vibration API: plumbing from Blink to Java.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/vibration/vibration_service_factory.h

Issue 16781002: Vibration API: plumbing from Blink to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/vibration/vibration_service.h ('K') | « content/browser/vibration/vibration_service.h ('k') | content/browser/vibration/vibration_service_impl_android.h » ('j') | content/browser/vibration/vibration_service_impl_android.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_FACTORY_H_

	6 #define CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_FACTORY_H_

	7

	8 #if defined(OS_ANDROID)

	9 #include "content/browser/vibration/vibration_service_impl_android.h"

	10 #else

	11 #include "content/browser/vibration/vibration_service_impl_empty.h"
	Peter Beverloo 2013/06/13 11:27:45 Do we need an empty implementation? Can't we just Do we need an empty implementation? Can't we just return NULL if there is no appropriate implementation and then not handle it in the message filter? Having a factory seems a bit overkill, and is different from the normal paradigms we use for supporting multiple platforms. Michael van Ouwerkerk 2013/06/18 14:39:23 Done. Show quoted text On 2013/06/13 11:27:45, Peter Beverloo wrote: > Do we need an empty implementation? Can't we just return NULL if there is no > appropriate implementation and then not handle it in the message filter? Having > a factory seems a bit overkill, and is different from the normal paradigms we > use for supporting multiple platforms. Done.
	12 #endif

	13

	14 namespace content {

	15

	16 scoped_ptr<VibrationService> NewVibrationService() {

	17 #if defined(OS_ANDROID)

	18 return scoped_ptr<VibrationService>(new VibrationServiceImplAndroid());

	19 #else

	20 return scoped_ptr<VibrationService>(new VibrationServiceImplEmpty());

	21 #endif

	22 }

	23

	24 } // namespace content

	25

	26 #endif // CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_FACTORY_H_

OLD	NEW