content/browser/vibration/vibration_service.h - Issue 16781002: Vibration API: plumbing from Blink to Java.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/vibration/vibration_service.h

Issue 16781002: Vibration API: plumbing from Blink to Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/vibration/vibration_browser_message_filter.cc ('K') | « content/browser/vibration/vibration_browser_message_filter.cc ('k') | content/browser/vibration/vibration_service_factory.h » ('j') | content/browser/vibration/vibration_service_factory.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_H_

	6 #define CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_H_

	7

	8 namespace content {

	9

	10 class VibrationService {

	11 public:

	12 virtual ~VibrationService() {}
	Peter Beverloo 2013/06/13 11:27:45 nit: empty line below this one. nit: empty line below this one. Michael van Ouwerkerk 2013/06/18 14:39:23 Done. Show quoted text On 2013/06/13 11:27:45, Peter Beverloo wrote: > nit: empty line below this one. Done.
	13 virtual void Vibrate(unsigned time) = 0;
	Peter Beverloo 2013/06/13 11:27:45 Since this is an empty interface, let's add some c Since this is an empty interface, let's add some comments to clarify what the expected behavior is (like the Platform API: units, what happens when a vibration is already active, can CancelVibration() be called when no vibration is active?) Michael van Ouwerkerk 2013/06/18 14:39:23 Done. Show quoted text On 2013/06/13 11:27:45, Peter Beverloo wrote: > Since this is an empty interface, let's add some comments to clarify what the > expected behavior is (like the Platform API: units, what happens when a > vibration is already active, can CancelVibration() be called when no vibration > is active?) Done.
	14 virtual void CancelVibration() = 0;

	15 };

	16

	17 } // namespace content

	18

	19 #endif // CONTENT_BROWSER_VIBRATION_VIBRATION_SERVICE_H_

OLD	NEW