webrtc/modules/desktop_capture/desktop_frame_win.h - Issue 1678073003: Cleanup shared memory handling in DesktopCapturer interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/desktop_frame_win.h

Issue 1678073003: Cleanup shared memory handling in DesktopCapturer interface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/desktop_capture/desktop_capturer.h ('K') | « webrtc/modules/desktop_capture/desktop_frame.cc ('k') | webrtc/modules/desktop_capture/desktop_frame_win.cc » ('j') | webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/desktop_frame_win.h

diff --git a/webrtc/modules/desktop_capture/desktop_frame_win.h b/webrtc/modules/desktop_capture/desktop_frame_win.h

index 15b5883c36fa63642f7cf273b959fb39e6ea9425..fffaeab54e3fb098a1e34e924d882ae9144a78c2 100644

--- a/webrtc/modules/desktop_capture/desktop_frame_win.h

+++ b/webrtc/modules/desktop_capture/desktop_frame_win.h

@@ -25,7 +25,7 @@ class DesktopFrameWin : public DesktopFrame {

public:

virtual ~DesktopFrameWin();

static DesktopFrameWin* Create(DesktopSize size,

- SharedMemory* shared_memory,

+ SharedMemoryFactory* shared_memory_factory,

HDC hdc);

HBITMAP bitmap() { return bitmap_; }

@@ -34,7 +34,7 @@ class DesktopFrameWin : public DesktopFrame {

DesktopFrameWin(DesktopSize size,

int stride,

uint8_t* data,

- SharedMemory* shared_memory,

+ rtc::scoped_ptr<SharedMemory> shared_memory,

HBITMAP bitmap);

HBITMAP bitmap_;