Fix super noSuchMethod handling.

Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is fixed with this CL, including the addition the missing visitUnresolvedSuperSet method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed: https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078

Reverted: https://github.com/dart-lang/sdk/commit/a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e

Committed: https://github.com/dart-lang/sdk/commit/059f44aa3b0ca0915420f6d93db7409647385d3c

[Johnni Winther, 2016-02-08 11:05:10]

Description was changed from

==========
Fix super noSuchMethod handling.

Closes #25680
==========

to

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)
==========

[Johnni Winther, 2016-02-08 11:05:53]

johnniwinther@google.com changed reviewers:
+ asgerf@google.com, het@google.com

[Harry Terkelsen, 2016-02-08 17:51:27]

lgtm

[asgerf, 2016-02-08 18:42:45]

lgtm

https://codereview.chromium.org/1678053002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1678053002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3342: List<ir.Primitive>
arguments) {
The name of this method doesn't seem right anymore. Do all the uses of this
method require the super lookup semantics? If so, could you please rename this
to buildSuperNoSuchMethod or something like that?

[Johnni Winther, 2016-02-09 08:37:29]

https://codereview.chromium.org/1678053002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1678053002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3342: List<ir.Primitive>
arguments) {
On 2016/02/08 18:42:44, asgerf wrote:
> The name of this method doesn't seem right anymore. Do all the uses of this
> method require the super lookup semantics? If so, could you please rename this
> to buildSuperNoSuchMethod or something like that?

Done.

[Johnni Winther, 2016-02-09 10:39:48]

Description was changed from

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)
==========

to

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078
==========

[Johnni Winther, 2016-02-09 10:39:50]

Committed patchset #5 (id:80001) manually as
756d95a372b5123193644f07b65b93c106a92078 (presubmit successful).

[Johnni Winther, 2016-02-09 12:09:07]

Description was changed from

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078
==========

to

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078

Reverted:
https://github.com/dart-lang/sdk/commit/a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e
==========

[Johnni Winther, 2016-02-09 13:58:00]

PTAL @ the last patch

[asgerf, 2016-02-09 14:00:36]

lgtm

[Johnni Winther, 2016-02-09 14:20:32]

Description was changed from

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078

Reverted:
https://github.com/dart-lang/sdk/commit/a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e
==========

to

==========
Fix super noSuchMethod handling.

Closes #25680

- This CL fixes the handling of inapplicable noSuchMethod methods on
superclasses (see issue 25671) for both SSA and CPS.
- The CPS implementation for normal noSuchMethod calls on super was wrong is
fixed with this CL, including the addition the missing visitUnresolvedSuperSet
method  on the SemanticSendVisitor.
- An error (presumably in type inference) affecting SSA was found with the added
tests (Issue 25716 filed)

R=asgerf@google.com, het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/756d95a372b5123193644f07b65b93c106a92078

Reverted:
https://github.com/dart-lang/sdk/commit/a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e

Committed:
https://github.com/dart-lang/sdk/commit/059f44aa3b0ca0915420f6d93db7409647385d3c
==========

[Johnni Winther, 2016-02-09 14:20:33]

Committed patchset #7 (id:90022) manually as
059f44aa3b0ca0915420f6d93db7409647385d3c (presubmit successful).